Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random issues with quick fixes #52

Open
ankur-p opened this issue Aug 16, 2024 · 0 comments
Open

Random issues with quick fixes #52

ankur-p opened this issue Aug 16, 2024 · 0 comments

Comments

@ankur-p
Copy link

ankur-p commented Aug 16, 2024

First of all, I'd like to thank you for writing up this script. It's been a great help :)

I've found a couple of little issues that I had to fix to get this to work properly in Docker.

main.py

107- f.write(response.content)
107+ f.write(r.content)

entrypoint.sh

1- pip install -r /app/requirements.txt
2- python /app/main.py -e $EMAIL -p $PASSWORD -d /app/book -b pdf,mobi,epub,code

1+ pip install -r /app/requirements.txt --trusted-host pypi.python.org --trusted-host files.pythonhosted.org --trusted-host pypi.org \
2+     && python /app/main.py -e $EMAIL -p $PASSWORD -d /app/book -b pdf,mobi,epub,code -s

Also, should probably add "book/" to .gitignore

I can open a quick PR for this if you want, or you can roll this into a future update. Feel free to let me know if you'd like me to do it, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant