Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nan bug #57

Open
cddlyf opened this issue Aug 29, 2017 · 3 comments
Open

Nan bug #57

cddlyf opened this issue Aug 29, 2017 · 3 comments

Comments

@cddlyf
Copy link

cddlyf commented Aug 29, 2017

In the line 33-35 of accum_layer.cu, the latter number of min should be "src_count -1" but not src_count, I guess this may be the reason why you add some NAN processing code in the demo python script. Just some personal guess.

@nikolausmayer
Copy link
Contributor

Oh... thanks! That looks embarrassing 😦
I'll keep this issue open until I can push a fix.

Best,
Nikolaus

@cddlyf
Copy link
Author

cddlyf commented Sep 1, 2017

@nikolausmayer BTW, in my personal view, I don't think change to "src_count - 1" is reasonable. For example, for element in the last row, you cannot interpolate it by regarding “src_count” (bottom, right corner) as its 4-neighborhood.

@KeyKy
Copy link

KeyKy commented Sep 28, 2017

I think

if (srcIdxOff+1 > src_count - 1 || srcIdxOff+1 < 0)
    continue;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants