Skip to content

Commit 4fbe77a

Browse files
authored
[dynamo] Verify the default value is passed by kwargs (#2998)
1 parent f173a06 commit 4fbe77a

File tree

2 files changed

+5
-11
lines changed

2 files changed

+5
-11
lines changed

projects/pt1/e2e_testing/xfail_sets.py

+4-10
Original file line numberDiff line numberDiff line change
@@ -252,18 +252,14 @@
252252
# ERROR: Exception: Unsupported: missing default value for argument 0 in schema for aten.div.Tensor_mode
253253
"ElementwiseAtenFloorDivideScalarNegativeModule_basic",
254254
"ElementwiseAtenFloorDivideScalarModule_basic",
255-
"ElementwiseDivTensorRoundingModeFloorModule_basic",
256-
"ElementwiseDivTensorRoundingModeTruncModule_basic",
257-
"ElementwiseDivTensorRoundingModeFloorStaticModule_basic",
258-
"ElementwiseDivTensorRoundingModeTruncStaticModule_basic",
259-
"ElementwiseDivTensorRoundingModeFloorIntStaticModule_basic",
260-
"ElementwiseDivTensorRoundingModeTruncIntStaticModule_basic",
261255
"ElementwiseDivScalarRoundingModeFloorModule_basic",
262256
"ElementwiseDivScalarRoundingModeTruncModule_basic",
263257
"ElementwiseDivScalarRoundingModeFloorStaticModule_basic",
264258
"ElementwiseDivScalarRoundingModeTruncStaticModule_basic",
265259
"ElementwiseDivScalarRoundingModeFloorIntStaticModule_basic",
266260
"ElementwiseDivScalarRoundingModeTruncIntStaticModule_basic",
261+
262+
# ERROR: 'torch.aten.mul.Tensor' op operand #1 must be Any Torch tensor type, but got '!torch.int'
267263
"AdaptiveAvgPool1dStaticLargerOutput_basic",
268264
"AdaptiveAvgPool1dGeneralDynamic_basic",
269265
"AdaptiveAvgPool1dGeneralDynamicNoBatches_basic",
@@ -276,10 +272,6 @@
276272
"TensorFloatModule_basic",
277273
"TensorIntModule_basic",
278274

279-
# ERROR: Exception: Unsupported: missing default value for argument 0 in schema for aten.randn.generator
280-
"RandnGeneratorF64Module_basic",
281-
"RandnGeneratorModule_basic",
282-
283275
# START tests failing due to: complex floating point ops
284276
# END tests failing due to: complex floating point ops
285277

@@ -343,8 +335,10 @@
343335
"IntImplicitModule_basic",
344336

345337
# Others
338+
"ExponentialModule_basic",
346339
"GridSamplerBasic1_basic",
347340
"GridSamplerBasic2_basic",
341+
"GridSamplerBasic3_basic",
348342
"FakeQuantizePerTensorAffineModule_basic",
349343
"FakeQuantizePerTensorAffineDynamicShapeModule_basic",
350344
"FakeQuantizePerTensorAffineRoundToEvenModule_basic",

projects/pt1/python/torch_mlir/_dynamo_fx_importer.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ def _check_meta_val(node):
7878
assert len(node.args) < len(node.target._schema.arguments)
7979
for i, argument in enumerate(
8080
node.target._schema.arguments[len(node.args):]):
81-
if not argument.has_default_value():
81+
if not argument.has_default_value() and argument.name not in node.kwargs:
8282
raise Exception(
8383
f"Unsupported: missing default value for argument {i} in schema for {node.target}"
8484
)

0 commit comments

Comments
 (0)