Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL] Parser Accepts Duplicated Names Under Layerblock #7773

Open
seldridge opened this issue Nov 5, 2024 · 1 comment
Open

[FIRRTL] Parser Accepts Duplicated Names Under Layerblock #7773

seldridge opened this issue Nov 5, 2024 · 1 comment
Labels
bug Something isn't working FIRRTL Involving the `firrtl` dialect good first issue Good for newcomers

Comments

@seldridge
Copy link
Member

The following should be illegal, but is currently parsed:

FIRRTL version 4.0.0
circuit Foo:
  layer A, bind:
  public module Foo:

    layerblock A:
      wire a: UInt<1>

    wire a: UInt<1>

If the layerblock is moved after the second wire definition, then the correct error is produced.
@seldridge seldridge added bug Something isn't working good first issue Good for newcomers FIRRTL Involving the `firrtl` dialect labels Nov 5, 2024
@youngar
Copy link
Member

youngar commented Nov 5, 2024

Related to #1537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working FIRRTL Involving the `firrtl` dialect good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seldridge @youngar