Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random Battleground is always 10vs10 #921

Open
Meteorika opened this issue Jan 28, 2025 · 16 comments
Open

Random Battleground is always 10vs10 #921

Meteorika opened this issue Jan 28, 2025 · 16 comments
Labels
bug Something isn't working

Comments

@Meteorika
Copy link

Whenever I join bgs via Random BG, it populates only for 10vs10, which is a an issue for Alterac Valley and Isle of Conquest.
I set 'AiPlayerbot.RandomBotJoinBG = 1' and 'AiPlayerbot.RandomBotAutoJoinBG = 1', to no avail

@nl-saw nl-saw added the bug Something isn't working label Jan 28, 2025
@blinkysc
Copy link
Contributor

I cant reproduce this?

@noisiver
Copy link
Collaborator

I know this has been a thing in the past. I can't remember why it happened but some people did suffer from it.

I think it happened under specific conditions but I can't remember what they were, it's been a long time.

It would help if the OP included any information about the commit of azerothcore and the playerbots module they're using, the settings their using etc.

@nl-saw
Copy link
Collaborator

nl-saw commented Jan 30, 2025

I confirmed the issue when I put the bug label, only using Playerbots module. When queuing for random and ending up in AV, it is 10v10 (at least here and the very first BG was AV). You guys saying this is not the case for you @blinkysc / @noisiver ?

@blinkysc
Copy link
Contributor

Seems like @noisiver was a bug under certain conditions in past so may very well be valid. I haven't seen it myself

@noisiver
Copy link
Collaborator

I know for sure this has been an issue in the past but it's been a while since I heard about it so I assumed it was gone but I don't have access to the random battleground queue in the patch I'm playing so I never ran into it.

With your confirmation the OP clearly doesn't need to include any extra information so ignore that. 👍

@nl-saw
Copy link
Collaborator

nl-saw commented Jan 30, 2025

Edit: Issue confirmed by @blinkysc as well. Probably not config related.

@blinkysc
Copy link
Contributor

I think it comes from AC core with GetMaxPlayersPerTeam()

@Meteorika
Copy link
Author

I fresh built 27 jan AzerothCore branch for playerbots, pulled playerbots and ahbot mods, SQL db was already existing, tho I wiped bots keeping my chars on it

@noisiver
Copy link
Collaborator

I fresh built 27 jan AzerothCore branch for playerbots, pulled playerbots and ahbot mods, SQL db was already existing, tho I wiped bots keeping my chars on it

Appreciated but it's not something you did that caused this issue. They've confirmed it happening on their end so it's something that happens to everyone, and it'll get fixed soon enough!

Thank you for reporting this issue.

@Meteorika
Copy link
Author

blinkysc was right(thanks man), battleground_template in acore_world db was faulty, MaxPlayersPerTeam was set at "10" for Random Battleground, currently I put "40" there and it works so far, I joined full 15vs15 AB

@blinkysc
Copy link
Contributor

Haha you found the fix, glad I could at least inspire you to look

@blinkysc
Copy link
Contributor

UPDATE battleground_template SET MaxPlayersPerTeam = 40 WHERE ID = 32;

Maybe we could add to wiki

@nl-saw
Copy link
Collaborator

nl-saw commented Jan 30, 2025

If setting it to 40 causes no harm, I suppose AC should rectify this on their end.

@nl-saw
Copy link
Collaborator

nl-saw commented Jan 30, 2025

Ok so the issue currently setting this to 40 is that bots will keep queuing for Random BG if the BG is actually less than 40. This will have a snowball effect. Some changes on our end would probably suit best in the end.

@Meteorika
Copy link
Author

Meteorika commented Jan 30, 2025

Ok so the issue currently setting this to 40 is that bots will keep queuing for Random BG if the BG is actually less than 40. This will have a snowball effect. Some changes on our end would probably suit best in the end.

Have the same outcome, nl-saw; Setting 'AiPlayerbot.RandomBotAutoJoinBG = 0' doesn't help, bots keep spamming rbgs when player queues rbg, until every single bot is in the bg, and they keep queuing even after player is done with the bg

@Meteorika
Copy link
Author

people, who cannot replicate, how different are your builds from the original, if at all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants