Loads of build warnings

[andymarden]

Describe the bug
Make gives lots of warnings. This occurs within the modded wotlk build without playerbot and even more with mod-playerbot. No such issues with the normal repo that it was forked from. Can't see Issues tab on the forked repo though.

Commit hash
Current as of point this was raised.

To Reproduce
Run the build of azerothcore (the modded version to allow mod-playerbots - following the instructions

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots

/home/azeroth/azerothcore/modules/mod-playerbots/src/TravelMgr.cpp:1377:35: warning: comparison of integers of different signs: 'uint32' (aka 'unsigned int') and 'int32' (aka 'int') [-Wsign-compare]
            if (target.GetEntry() == getEntry() && target.IsCreature() && botAI->GetCreature(target) &&
                ~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~
/home/azeroth/azerothcore/modules/mod-playerbots/src/TravelNode.cpp:1498:21: warning: unused variable 'endNode' [-Wunused-variable]
        TravelNode* endNode = path.first;
                    ^
/home/azeroth/azerothcore/modules/mod-playerbots/src/TravelNode.cpp:1641:25: warning: unused variable 'node' [-Wunused-variable]
            TravelNode* node = sTravelNodeMap->addNode(guidP, nodeName, true, true);
                        ^
/home/azeroth/azerothcore/modules/mod-playerbots/src/TravelNode.cpp:1757:21: warning: unused variable 'entryNode' [-Wunused-variable]
        TravelNode* entryNode = sTravelNodeMap->getNode(outPos, nullptr, 20.0f);  // Entry side, portal exit.
                    ^
/home/azeroth/azerothcore/modules/mod-playerbots/src/TravelNode.cpp:1979:21: warning: unused variable 'node' [-Wunused-variable]
        TravelNode* node = sTravelNodeMap->addNode(pos, pos.getAreaName(), true, true, false);
                    ^
/home/azeroth/azerothcore/modules/mod-playerbots/src/TravelNode.cpp:2120:20: warning: unused variable 'rem' [-Wunused-variable]
    uint32 it = 0, rem = 0;
                   ^
/home/azeroth/azerothcore/modules/mod-playerbots/src/TravelNode.cpp:2210:12: warning: unused variable 'nr' [-Wunused-variable]
    uint32 nr = 0;
           ^
/home/azeroth/azerothcore/modules/mod-playerbots/src/TravelMgr.cpp:3758:60: warning: unused parameter 'amount' [-Wunused-parameter]
                                                    uint32 amount)
                                                           ^
/home/azeroth/azerothcore/modules/mod-playerbots/src/TravelMgr.cpp:4012:12: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move]
    return std::move(retTravelLocations);
           ^
/home/azeroth/azerothcore/modules/mod-playerbots/src/TravelMgr.cpp:4012:12: note: remove std::move call here
    return std::move(retTravelLocations);

Desktop (please complete the following information):

• Debian 12

Additional context
Add any other context about the problem here.

[noisiver]

This has been a thing for as long as I can remember. Everyone gets it.

Edit: The exact warnings have changed over time but some kind of warning has always been there is what I mean.

[hermensbas]

We could prolly fix most of them, it only takes times.

[noisiver]

All of them could be fixed but as you say it's about time.