[connectivity] Fix unawaited futures (flutter#2313)

Michael Klimushyn · web-flow · commit dca2f4268352 · 2019-12-03T09:51:12.000-08:00
diff --git a/packages/connectivity/CHANGELOG.md b/packages/connectivity/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.4.5+7
+
+* Fix unawaited futures in the example app and tests.
+
 ## 0.4.5+6
 
 * Fix singleton Reachability problem on iOS.
diff --git a/packages/connectivity/analysis_options.yaml b/packages/connectivity/analysis_options.yaml
diff --git a/packages/connectivity/example/lib/main.dart b/packages/connectivity/example/lib/main.dart
@@ -71,10 +71,10 @@ class _MyHomePageState extends State<MyHomePage> {
     // message was in flight, we want to discard the reply rather than calling
     // setState to update our non-existent appearance.
     if (!mounted) {
-      return;
+      return Future.value(null);
     }
 
-    _updateConnectionStatus(result);
+    return _updateConnectionStatus(result);
   }
 
   @override
diff --git a/packages/connectivity/example/test_driver/test/connectivity_e2e_test.dart b/packages/connectivity/example/test_driver/test/connectivity_e2e_test.dart
@@ -9,6 +9,6 @@ Future<void> main() async {
   final FlutterDriver driver = await FlutterDriver.connect();
   final String result =
       await driver.requestData(null, timeout: const Duration(minutes: 1));
-  driver.close();
+  await driver.close();
   exit(result == 'pass' ? 0 : 1);
 }
diff --git a/packages/connectivity/pubspec.yaml b/packages/connectivity/pubspec.yaml
@@ -3,7 +3,7 @@ description: Flutter plugin for discovering the state of the network (WiFi &
   mobile/cellular) connectivity on Android and iOS.
 author: Flutter Team <flutter-dev@googlegroups.com>
 homepage: https://github.com/flutter/plugins/tree/master/packages/connectivity
-version: 0.4.5+6
+version: 0.4.5+7
 
 flutter:
   plugin:

Original file line number	Diff line number	Diff line change
`@@ -71,10 +71,10 @@ class _MyHomePageState extends State<MyHomePage> {`
`71`	`71`	`// message was in flight, we want to discard the reply rather than calling`
`72`	`72`	`// setState to update our non-existent appearance.`
`73`	`73`	`if (!mounted) {`
`74`		`- return;`
	`74`	`+ return Future.value(null);`
`75`	`75`	`}`
`76`	`76`
`77`		`- _updateConnectionStatus(result);`
	`77`	`+ return _updateConnectionStatus(result);`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`@override`
Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,6 @@ Future<void> main() async {`
`9`	`9`	`final FlutterDriver driver = await FlutterDriver.connect();`
`10`	`10`	`final String result =`
`11`	`11`	`await driver.requestData(null, timeout: const Duration(minutes: 1));`
`12`		`- driver.close();`
	`12`	`+ await driver.close();`
`13`	`13`	`exit(result == 'pass' ? 0 : 1);`
`14`	`14`	`}`