Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .template.config folder from project if Template Info Dialog Cancel clicked #10

Open
shaggygi opened this issue Aug 24, 2017 · 6 comments

Comments

@shaggygi
Copy link
Contributor

I noticed if you click Cancel button in Template Info Dialog, the files will still remain in the project. It would be nice to remove them. If not, it might be a good idea to document somewhere what was added to let the dev know what needs to be removed manually (especially since there are hidden files added during the process).

@sayedihashimi
Copy link
Member

Hi @shaggygi thanks for the issue. If you Cancel the dialog then the files should not be getting created on disk. I noticed that the .template.config directory was always getting created. I made changes in 52b2061 to prevent creation of the folder on Cancel as well.

Are you seeing some different behavior where the files are created on Cancel?

@shaggygi
Copy link
Contributor Author

shaggygi commented Sep 9, 2017

@sayedihashimi Sorry for delay. I verified and you are correct. The hidden .template.config folder is created, but not the files. I'll update issue title. Thx

@shaggygi shaggygi changed the title Remove related template files from project if Template Info Dialog Cancel clicked Remove .template.config folder from project if Template Info Dialog Cancel clicked Sep 9, 2017
@sayedihashimi
Copy link
Member

In the latest bits (not released yet) I already fixed the folder creation issue. The commit is linked above.

@codewithtyler
Copy link
Member

@sayedihashimi has this fixed been released?

@sayedihashimi
Copy link
Member

@tylerbhughes I think so, but not totally sure.

@codewithtyler
Copy link
Member

@sayedihashimi I've tested and confirmed that the .template.config file does not get deleted if you click the cancel button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants