Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using / for Division deprecation warning #1180

Open
2 of 7 tasks
jwanner83 opened this issue Nov 2, 2023 · 2 comments
Open
2 of 7 tasks

Using / for Division deprecation warning #1180

jwanner83 opened this issue Nov 2, 2023 · 2 comments

Comments

@jwanner83
Copy link

jwanner83 commented Nov 2, 2023

Issue type (mark with x)

  • πŸ€” Question
  • πŸ› Bug report
  • 🎁 Feature request
  • πŸ€·β€β™€οΈ Other

Version (mark with x)

  • 8️⃣ v8.x
  • 9️⃣ v9.x
  • πŸ”Ÿ v10.x or higher

Description

Desired behavior:

As described in the documentation (https://github.com/liferay/liferay-frontend-projects/tree/master/projects/js-themes-toolkit/packages/liferay-theme-tasks#using--for-division-deprecation-warning) the deprecation warning of using / for division should disappear after adding @use "sass:math" as *; to the top of _clay_variables.scss.

Current behavior:

The warning still exists, even after adding the line.

Reproduction steps:

  1. create a theme with the liferay theme generator for 7.4
  2. run build <- error exists
  3. add _clay_variables.scss in src and add the @use "sass:math" as *; line on top of it
  4. run build again <- error still exists

Other information (environment, versions etc):

  "gulp": "^4.0.2";
  "liferay-frontend-css-common": "^6.0.8",
  "liferay-frontend-theme-styled": "^6.0.66",
  "liferay-frontend-theme-unstyled": "^6.0.54",
  "liferay-theme-tasks": "11.4.0",
@bryceosterhaus
Copy link
Member

cc @pat270, I see you were the one to add the docs for this

@jwanner83
Copy link
Author

@pat270 were you able to take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants