Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sponsor Block is not working in "FULL LOCAL MODE" #7193

Open
3 tasks done
Golukumar00 opened this issue Mar 13, 2025 · 2 comments · May be fixed by #7195
Open
3 tasks done

Sponsor Block is not working in "FULL LOCAL MODE" #7193

Golukumar00 opened this issue Mar 13, 2025 · 2 comments · May be fixed by #7195
Labels
enhancement New feature or request

Comments

@Golukumar00
Copy link

Steps to reproduce

when I use the app without turning ON " Full local Mode" sponser block works but when I On the setting it doesn't work at all.
Here is the video 🔗 https://youtu.be/LJOQKpAfvqU

Expected behavior

This should be working

Actual behavior

Not working

LibreTube version

Recent nightly build

Android version

Android 12

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@Golukumar00 Golukumar00 added the bug Something isn't working label Mar 13, 2025
@FineFindus
Copy link
Contributor

I think that is intended, as SponsorBlock is not something that can be locally extracted (i.e. requiring an external service) and the method explicitly returns an empty Segment:

However, Dislikes are still fetched when in local in full local mode, so I think it makes sense to also enable SponsorBlock, etc. I'm happy to make a PR for that.

@Bnyro
Copy link
Member

Bnyro commented Mar 13, 2025

However, Dislikes are still fetched when in local in full local mode, so I think it makes sense to also enable SponsorBlock, etc. I'm happy to make a PR for that.

We use Piped's API for fetching sponsor segments when not using local mode, hence it's been left unimplemented here. We can indeed use the SponsorBlock API directly, but I didn't do that yet because I only wanted to focus on the core functionality in the beginnings of implementing NPE support.

PRs welcome.

@Bnyro Bnyro added enhancement New feature or request and removed bug Something isn't working labels Mar 13, 2025
FineFindus added a commit to FineFindus/LibreTube that referenced this issue Mar 13, 2025
Allows users to use SponsorBlock when using full local mode.

Closes: libre-tube#7193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants