You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
when I use the app without turning ON " Full local Mode" sponser block works but when I On the setting it doesn't work at all.
Here is the video 🔗 https://youtu.be/LJOQKpAfvqU
Expected behavior
This should be working
Actual behavior
Not working
LibreTube version
Recent nightly build
Android version
Android 12
Other details
No response
Acknowledgements
I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
I have written a short but informative title.
I will fill out all of the requested information in this form.
The text was updated successfully, but these errors were encountered:
I think that is intended, as SponsorBlock is not something that can be locally extracted (i.e. requiring an external service) and the method explicitly returns an empty Segment:
However, Dislikes are still fetched when in local in full local mode, so I think it makes sense to also enable SponsorBlock, etc. I'm happy to make a PR for that.
However, Dislikes are still fetched when in local in full local mode, so I think it makes sense to also enable SponsorBlock, etc. I'm happy to make a PR for that.
We use Piped's API for fetching sponsor segments when not using local mode, hence it's been left unimplemented here. We can indeed use the SponsorBlock API directly, but I didn't do that yet because I only wanted to focus on the core functionality in the beginnings of implementing NPE support.
Steps to reproduce
when I use the app without turning ON " Full local Mode" sponser block works but when I On the setting it doesn't work at all.
Here is the video 🔗 https://youtu.be/LJOQKpAfvqU
Expected behavior
This should be working
Actual behavior
Not working
LibreTube version
Recent nightly build
Android version
Android 12
Other details
No response
Acknowledgements
The text was updated successfully, but these errors were encountered: