Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebkitGTK implementations don't currently support WebRTC #2007

Closed
maschad opened this issue Aug 30, 2023 · 3 comments
Closed

WebkitGTK implementations don't currently support WebRTC #2007

maschad opened this issue Aug 30, 2023 · 3 comments
Assignees
@maschad
Labels
status/blocked Unable to be worked further until needs are met

Comments

@maschad
Copy link
Member

maschad commented Aug 30, 2023 •
edited
Loading

I did some more research/testing and found that WebkitGTK (the full-featured port of the WebKit rendering engine on Linux-based OS's) does not yet support the PeerConnection API. Igalia is currently working on the implementation but this is obviously a blocker for Playwright supporting this interface as per the docs

Thanks to @MarcoPolo for pointing me in this direction.

Originally posted by @maschad in libp2p/js-libp2p-webrtc#177 (comment)

I suppose this is why this it marked as experimental
@maschad maschad added the kind/bug A bug in existing code (including security flaws) label Aug 30, 2023
@maschad maschad added the status/blocked Unable to be worked further until needs are met label Aug 30, 2023
This was referenced Aug 30, 2023
Closed
Closed
@maschad maschad moved this to 🥞Weekly Candidates/Discuss🎙 in js-libp2p Aug 30, 2023
@maschad maschad moved this from 🥞Weekly Candidates/Discuss🎙 to 🧱Blocked in js-libp2p Sep 5, 2023
@dhuseby
Copy link
Contributor

dhuseby commented May 7, 2024

@maschad to run some tests on CI to see if this is unblocked

@maschad maschad mentioned this issue May 11, 2024
Merged
3 tasks
@maschad maschad moved this from 🧱Blocked to 🥸In Review in js-libp2p May 14, 2024
@dhuseby dhuseby moved this from 🥸In Review to 🏃‍♀️In Progress in js-libp2p May 14, 2024
@dhuseby
Copy link
Contributor

dhuseby commented May 21, 2024

Still blocked due to WebKit not fully supporting WebRTC

@dhuseby dhuseby moved this from 🏃‍♀️In Progress to 🧱Blocked in js-libp2p May 21, 2024
@achingbrain achingbrain removed the kind/bug A bug in existing code (including security flaws) label Feb 4, 2025
@achingbrain achingbrain changed the title Bug: WebkitGTK implementations don't currently support WebRTC WebkitGTK implementations don't currently support WebRTC Feb 4, 2025
@achingbrain
Copy link
Member

The tests pass now, all good.

@github-project-automation github-project-automation bot moved this from 🧱Blocked to 🎉Done in js-libp2p Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maschad maschad

Labels
status/blocked Unable to be worked further until needs are met
Projects
js-libp2p
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@achingbrain @dhuseby @maschad