Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look of code #49

Open
hdrdavies opened this issue Sep 26, 2015 · 6 comments
Open

Look of code #49

hdrdavies opened this issue Sep 26, 2015 · 6 comments

Comments

@hdrdavies
Copy link
Contributor

I reckon we beautify our code and stick all the variables at the top of our functions. Happy to do this tomorrow.

p.s. I wanted to keep the streak going.

@Jbarget
Copy link
Member

Jbarget commented Sep 27, 2015

ugh forgot about the streak yesterday!
noooo

@Jbarget
Copy link
Member

Jbarget commented Sep 27, 2015

but yeh agree, go for it

@RachBLondon
Copy link
Member

Good idea Huw, do you recon we should also put the guardian.js in one function to help prevent global variables?
I lost my streak yesterday 👎

@hdrdavies
Copy link
Contributor Author

Oh this email thread thing is cool isn't it. I'm not sure how we put it al
in one function but more than happy to have that.

On Sun, Sep 27, 2015 at 12:47 PM, Rachel [email protected] wrote:

Good idea Huw, do you recon we should also put the guardian.js in one
function to help prevent global variables?
I lost my streak yesterday [image: 👎]


Reply to this email directly or view it on GitHub
#49 (comment).

@rug1
Copy link

rug1 commented Sep 27, 2015

I've created a pull request for the beautifying code if you guys wanna take a look. Kept up my streak woohoo!

@RachBLondon
Copy link
Member

looks good with the var at the top each function :-)

Do you want to go through this tomorrow, or am I ok to merge this?

Rach

On 27 September 2015 at 18:39, Ruth Uwemedimo [email protected]
wrote:

I've created a pull request for the beautifying code if you guys wanna
take a look. Kept up my streak woohoo!


Reply to this email directly or view it on GitHub
#49 (comment).

Rachel Black

Linkedin
https://www.linkedin.com/profile/view?id=338501570&trk=nav_responsive_tab_profile_pic
Twitter https://twitter.com/RachelBLondon Behance
https://www.behance.net/Rachelblondon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants