Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Domain Expiration feature - Add Expiration Badge & Tooltip #1023

Closed
Tracked by #1029
Kevils opened this issue Feb 5, 2025 · 11 comments
Closed
Tracked by #1029

Update the Domain Expiration feature - Add Expiration Badge & Tooltip #1023

Kevils opened this issue Feb 5, 2025 · 11 comments
Assignees
Labels
Good first issue Good for newcomers ODHack12 Issue reserved for the OD Build Open for contribution An issue that is available for an Only Dust contribution

Comments

@Kevils
Copy link
Collaborator

Kevils commented Feb 5, 2025

Description 📹

Current :
Image

New design :
Image
Image

Figma : https://www.figma.com/design/S1UKYgWewNqNHZFAaBUilG/%F0%9F%8F%9D%EF%B8%8F-Starknet-ID?node-id=5250-7266&t=2SkxW4DSGWHqE5Q7-1

When a domain has an expiration, a red badge appears to the right of the name. It is then possible to hover over the badge to display a tooltip explaining the origin of the 'domain expired' badge

Proposed Actions 🛠️

Here’s a checklist of actions to follow for resolving this issue:

  1. Fork and Create Branch:
    Fork the repository and create a new branch using the issue number:

    git checkout -b fix-[issue-number]
  2. Implement Changes:
    [Insert Code snippet if needed with a mardown todo list]

  3. Run Tests and Commit Changes:
    Make sure your changes don't break existing functionality and commit with a clear message:

    git commit -m "Fix: [Short description of the fix]"

Required 📋

To keep our workflow smooth, please make sure you follow these guidelines:

  • Assignment: Don't create a pull request if you weren’t assigned to this issue.
  • Timeframe: Complete the task within 3 business days.
  • Closing the Issue: In your PR description, close the issue by writing Close #[issue_id].
  • Review Process:
    • Once you've submitted your PR, change the label to "ready for review".
    • If changes are requested, address them and then update the label back to "ready for review" once done.
  • Testing: Test your PR locally before pushing, and verify that tests and build are working after pushing.

Thank you for your contribution 🙏

⚠️ WARNING: Failure to follow the requirements above may result in being added to the OnlyDust blacklist, affecting your ability to receive future rewards.

@Kevils Kevils added Good first issue Good for newcomers Open for contribution An issue that is available for an Only Dust contribution and removed Good first issue Good for newcomers Open for contribution An issue that is available for an Only Dust contribution labels Feb 5, 2025
@Kevils Kevils changed the title Add Expiration Badge & Tooltip Update the Domain Expiration feature - Add Expiration Badge & Tooltip Feb 5, 2025
@TheRanomial
Copy link
Contributor

May I be assigned to this?ETA - 24 hours.

@Elite-tch
Copy link
Contributor

May I be assigned to this?

@SudiptaPaul-31
Copy link

Would love to work on this issue

@BigBen-7
Copy link

BigBen-7 commented Feb 8, 2025

hey there, can i work on this?
ETA: 24HOURS

@pheobeayo
Copy link
Contributor

May I be assigned to this?

@PedroCo3lho
Copy link

Can I work on this issue?
The check can be done before rendering the page and page and store it in the context, then I can implement the new design of a flagging the expired identity and apply the hover with the tooltip.
Let me know if it sounds good

@blessingbytes
Copy link
Contributor

would love to tackle this issue

@Kevils Kevils added Good first issue Good for newcomers ODHack12 Issue reserved for the OD Build Open for contribution An issue that is available for an Only Dust contribution labels Feb 17, 2025
@tali-creator
Copy link
Contributor

Can I take this from here?

@dare117
Copy link

dare117 commented Feb 22, 2025

Could I take a shot at this?

I've got 5+ years of experience working in the frontend ecosystem (ts, js, react, vue etc..) and I'm looking forward to make my first contribution.

Thanks.

@SamarthJ2004
Copy link

Hi, I’d love to take this up! 🚀

Approach
• Conditional Badge Rendering: Display a red badge next to the domain name when expirationDate < currentDate.
• Tooltip Integration: Show a tooltip (title attribute or a popover component) on hover, explaining why the badge appears.
• Optimized Rendering: Use memoization or class-based conditions to avoid unnecessary re-renders.
• Testing: Validate UI with Jest/RTL and manual checks for hover behavior.

Why Me?

I have good experience in React, dynamic UI rendering, and tooltip implementations, ensuring smooth and efficient execution.

Looking forward to contributing! 🔧

@PedroCo3lho
Copy link

On it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Good for newcomers ODHack12 Issue reserved for the OD Build Open for contribution An issue that is available for an Only Dust contribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.