Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize release zip files #7

Open
jcs090218 opened this issue Jun 11, 2023 · 2 comments
Open

Standardize release zip files #7

jcs090218 opened this issue Jun 11, 2023 · 2 comments

Comments

@jcs090218
Copy link
Member

In order to make this GHA work, we need to standardize the zip files from the release page:

There are two issues.

❓ Issue 1: Zipped files are unorganized

Linux:

Windows:

I preferred to organize like Windows, so all files are in the root level. 😉

❓ Issue 2: Extensions are different

The zipped file names are:

It's easier to have the same extensions (maybe all .zip?). Of course, this is easy to fix in the code, but I would like to acknowledge the Lem's author about this.

cc @cxxxr

@cxxxr
Copy link
Member

cxxxr commented Jun 12, 2023

Yes indeed, it may be difficult to handle because it is inconsistent.

About Issue 1, I think either is fine as long as they are unified.

About issue 2, the reason why only linux is tar.gz is because you can't extract the zip unless you put unzip in apt or something.
It might be a good idea to prepare both tar.gz and zip files.

@jcs090218
Copy link
Member Author

About Issue 1, I think either is fine as long as they are unified.

👍

About issue 2, the reason why only linux is tar.gz is because you can't extract the zip unless you put unzip in apt or something.
It might be a good idea to prepare both tar.gz and zip files.

It's a good reason! Let me make changes in the code instead, so we don't have to release two versions! 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants