You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardexpand all lines: .github/CONTRIBUTING.md
+9-36
Original file line number
Diff line number
Diff line change
@@ -25,14 +25,16 @@ By participating in this project you agree to abide by its terms.
25
25
26
26
* Fork the repo.
27
27
* Create a separate branch for your change.
28
-
* We only take pull requests with passing tests, and documentation. [travis-ci](http://travis-ci.org) runs the tests for us. You can also execute them locally. This is explained [in a later section](#the-test-matrix).
28
+
* We only take pull requests with passing tests, and documentation. [GitHub Actions](https://docs.github.com/en/actions) run the tests for us. You can also execute them locally. This is explained [in a later section](#the-test-matrix).
29
29
* Checkout [our docs](https://voxpupuli.org/docs/reviewing_pr/) we use to review a module and the [official styleguide](https://puppet.com/docs/puppet/6.0/style_guide.html). They provide some guidance for new code that might help you before you submit a pull request.
30
30
* Add a test for your change. Only refactoring and documentation changes require no new tests. If you are adding functionality or fixing a bug, please add a test.
31
31
* Squash your commits down into logical components. Make sure to rebase against our current master.
32
32
* Push the branch to your fork and submit a pull request.
33
33
34
34
Please be prepared to repeat some of these steps as our contributors review your code.
35
35
36
+
Also consider sending in your profile code that calls this component module as an acceptance test or provide it via an issue. This helps reviewers a lot to test your use case and prevents future regressions!
37
+
36
38
## Writing proper commits - short version
37
39
38
40
* Make commits of logical units.
@@ -230,50 +232,21 @@ simple tests against it after applying the module. You can run this
230
232
with:
231
233
232
234
```sh
233
-
bundle exec rake acceptance
234
-
```
235
-
236
-
This will run the tests on the module's default nodeset. You can override the
For more information and tips & tricks, see [voxpupuli-acceptance's documentation](https://github.com/voxpupuli/voxpupuli-acceptance#running-tests).
277
250
278
251
The source of this file is in our [modulesync_config](https://github.com/voxpupuli/modulesync_config/blob/master/moduleroot/.github/CONTRIBUTING.md.erb)
0 commit comments