Skip to content

Commit b6cf135

Browse files
committed
C#: Update @name for two queries
1 parent c7983a0 commit b6cf135

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

Diff for: change-notes/1.21/analysis-csharp.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ C# analysis now supports the extraction and analysis of many C# 8 features. For
88

99
| **Query** | **Tags** | **Purpose** |
1010
|-----------------------------------------------|------------------------------------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
11-
| Class defines a field that uses an ICryptoTransform class in a way that would be unsafe for concurrent threads (`cs/thread-unsafe-icryptotransform-field-in-class`) | concurrency, security, external/cwe/cwe-362 | Highlights classes with fields that make use of a static `System.Security.Cryptography.ICryptoTransform` object. Using these classes in concurrent threads is dangerous. It may result in an error and may also give incorrect results. Results are not shown on [LGTM](https://lgtm.com/rules/1507931833866/) by default. |
12-
| Potential usage of an object implementing ICryptoTransform class in a way that would be unsafe for concurrent threads (`cs/thread-unsafe-icryptotransform-captured-in-lambda`) | concurrency, security, external/cwe/cwe-362 | Highlights instances of classes where a field of type `System.Security.Cryptography.ICryptoTransform` is captured by a lambda, and appears to be used in a thread initialization method. Results are not shown on [LGTM](https://lgtm.com/rules/1508141845995/) by default. |
11+
| Thread-unsafe use of a static ICryptoTransform field (`cs/thread-unsafe-icryptotransform-field-in-class`) | concurrency, security, external/cwe/cwe-362 | Highlights classes with fields that make use of a static `System.Security.Cryptography.ICryptoTransform` object. Using these classes in concurrent threads is dangerous. It may result in an error and may also give incorrect results. Results are not shown on [LGTM](https://lgtm.com/rules/1507931833866/) by default. |
12+
| Thread-unsafe capturing of an ICryptoTransform object (`cs/thread-unsafe-icryptotransform-captured-in-lambda`) | concurrency, security, external/cwe/cwe-362 | Highlights instances of classes where a field of type `System.Security.Cryptography.ICryptoTransform` is captured by a lambda, and appears to be used in a thread initialization method. Results are not shown on [LGTM](https://lgtm.com/rules/1508141845995/) by default. |
1313

1414
## Changes to existing queries
1515

Diff for: csharp/ql/src/Likely Bugs/ThreadUnsafeICryptoTransform.ql

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/**
2-
* @name Class defines a field that uses an ICryptoTransform class in a way that would be unsafe for concurrent threads
2+
* @name Thread-unsafe use of a static ICryptoTransform field
33
* @description The class has a field that directly or indirectly make use of a static System.Security.Cryptography.ICryptoTransform object.
44
* Using this an instance of this class in concurrent threads is dangerous as it may not only result in an error,
55
* but under some circumstances may also result in incorrect results.

Diff for: csharp/ql/src/Likely Bugs/ThreadUnsafeICryptoTransformLambda.ql

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/**
2-
* @name Potential usage of an object implementing ICryptoTransform class in a way that would be unsafe for concurrent threads.
2+
* @name Thread-unsafe capturing of an ICryptoTransform object
33
* @description An instance of a class that either implements or has a field of type System.Security.Cryptography.ICryptoTransform is being captured by a lambda,
44
* and used in what seems to be a thread initialization method.
55
* Using an instance of this class in concurrent threads is dangerous as it may not only result in an error,

0 commit comments

Comments
 (0)