Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing options to individually remove deleted notebooks (and notes on Android) from trash #10763

Open
Terrance opened this issue Jul 18, 2024 · 4 comments · May be fixed by #10786
Open

Missing options to individually remove deleted notebooks (and notes on Android) from trash #10763

Terrance opened this issue Jul 18, 2024 · 4 comments · May be fixed by #10786
Labels
bug It's a bug

Comments

@Terrance
Copy link

Operating system

Windows

Joplin version

3.0.12 (Windows), 3.0.7 (Android)

Desktop version info

Joplin 3.0.12 (prod, win32)

Client ID: 2ca5a676b7954ae89721faa06464e5e6
Sync Version: 3
Profile Version: 47
Keychain Supported: Yes

Revision: a64d6e3

Backup: 1.4.1
Cursor Sync: 2.1.0
Get Notebook ID: 1.0.1
Joplin Calendar: 1.2.0
Joplin Note Attachement rename: 1.2.2
Kanban: 1.0.7
Note overview: 1.7.1
Outline: 1.5.13

Joplin 3.0.7 (prod, android)

Client ID: d8e98c66054049f0b59e6d8c0db590b2
Sync Version: 3
Profile Version: 47
Keychain Supported: No

Joplin Calendar: 1.2.0
Outline: 1.5.13

Android API level: 33
WebView version: 126.0.6478.134
WebView package: com.google.android.webview
FTS enabled: 1
Hermes enabled: 1

Current behaviour

  1. Delete a notebook
  2. Right-click / long-press that notebook under Trash
    image

On Android, long-pressing a notebook only offers Remove or Cancel options. Long-pressing a note selects it, and the top bar only includes a restore option; the Delete submenu item is also disabled whilst the note is in the trash.

Expected behaviour

On desktop, notes themselves have two options: Restore note and Permanently delete note; I'd expect both notes and notebooks to have these options on all platforms.

Logs

No response
@Terrance Terrance added the bug It's a bug label Jul 18, 2024
personalizedrefrigerator added a commit to personalizedrefrigerator/joplin that referenced this issue Jul 18, 2024
@personalizedrefrigerator
Mobile: Partially fixes laurent22#10763: Support permanent note delet…
f47bd0d 
…ion on mobile
Repository owner deleted a comment from srivastavaarpit977 Jul 19, 2024
@personalizedrefrigerator personalizedrefrigerator linked a pull request Jul 25, 2024 that will close this issue
Open
@github-actions GitHub Actions
Copy link
Contributor

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

@github-actions github-actions bot added the stale An issue that hasn't been active for a while... label Aug 18, 2024
@Terrance
Copy link
Author

PR in progress?

@github-actions github-actions bot removed the stale An issue that hasn't been active for a while... label Aug 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

@github-actions github-actions bot added the stale An issue that hasn't been active for a while... label Sep 18, 2024
@Terrance
Copy link
Author

Still an issue -- @personalizedrefrigerator, any updates on what you've got so far?

@github-actions github-actions bot removed the stale An issue that hasn't been active for a while... label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug It's a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mobile: Resolves #10763: Support permanent note deletion on mobile personalizedrefrigerator/joplin
1 participant
@Terrance