Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated Classes #10

Open
sleepfinance opened this issue Aug 23, 2023 · 2 comments · May be fixed by #14
Open

Deprecated Classes #10

sleepfinance opened this issue Aug 23, 2023 · 2 comments · May be fixed by #14
Assignees
@ssx

Comments

@sleepfinance
Copy link

Illuminate\Contracts\Validation\Rule is deprecated.
Rules should now Implement
Illuminate\Contracts\Validation\ValidationRule instead
@ssx
Copy link
Contributor

ssx commented Aug 23, 2023

@sleepfinance super, drop a PR to fix.

@ssx ssx self-assigned this Sep 12, 2023
@ssx
Copy link
Contributor

ssx commented Sep 16, 2023

@sleepfinance you didn't drop a PR in to fix!

This is actually a bigger task than it seems as a chunk of code needs refactoring and we'll likely bump up a major version.

@parth391 parth391 linked a pull request Feb 28, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ssx ssx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix deprecated rule classes parth391/phone
2 participants
@ssx @sleepfinance