Skip to content

I would like to question, if you really need the interface in every case, as I learned it is good practise to start just using export type instead #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TimSusa opened this issue Mar 27, 2025 · 3 comments
Closed

I would like to question, if you really need the interface in every case, as I learned it is good practise to start just using export type instead #47

TimSusa opened this issue Mar 27, 2025 · 3 comments

Comments

@TimSusa
Copy link

TimSusa commented Mar 27, 2025

langchainjs-mcp-adapters/src/client.ts

Line 51 in b431314

export interface SSEConnection {

@benjamincburns
Copy link
Contributor

I'm not sure what you're asking here, sorry - can you please clarify?

@TimSusa
Copy link
Author

TimSusa commented Apr 3, 2025 •
edited
Loading

Is here maybe just simple

export type SSEConnection = {

enough instead of creating an interface?

@benjamincburns
Copy link
Contributor

There's no functional difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benjamincburns @TimSusa