rework info command

Author: pirog

cli/commands/info/index.js

@@ -1,5 +1,5 @@
+const {CliUx, Flags} = require('@oclif/core');
 const {BaseCommand} = require('../../lib/base-command');
-const {Flags} = require('@oclif/core');
 
 class PluginInfo extends BaseCommand {
   static description = 'shows plugin information';
@@ -19,37 +19,71 @@ class PluginInfo extends BaseCommand {
 
   // @TODO: some sort of full flag?
   static flags = {
+    all: Flags.boolean({
+      description: 'show all information',
+      default: false,
+    }),
     ...BaseCommand.globalFlags,
   };
 
   async run() {
-    const _ = require('lodash');
-    const sortBy = require('lodash/sortBy');
+    /*
+      // MVP plugin.yml
+      name: name,
+      description: info.description,
+      releaseNotesUrl: 'https://URL/to/CHANGELOG.yml',
+      // @todo: should we query for this?
+      // installedVersion: this.isInstalled ? this.version : 'Not Installed',
+      version: info.version,
+      repositoryUrl: info.repository,
+      author: info.author,
+      contributors: info.maintainers,
+      keywords: info.keywords,
+    };
+    */
+    // mods
+    const get = require('lodash/get');
     const prettify = require('../../../utils/prettify');
-    const {CliUx} = require('@oclif/core');
-
-    // get hyperdrive stuff
-    const {hyperdrive} = this.config;
-    const Plugin = hyperdrive.Plugin;
-
-    const {args, flags} = await this.parse(PluginInfo);
-    const data = await Plugin.info(args.plugin);
-    if (flags.json) return data;
-
-    // Format data for table display.
-    const tableKeys = hyperdrive.Config.keys(data, {expandArrays: false});
-
-    const rows = _(tableKeys)
-    .filter(path => _.includes(tableKeys, path))
-    .map(path => ({key: path, value: _.get(data, path)}))
-    .value();
-
-    this.log();
-    CliUx.ux.table(sortBy(rows, 'key'), {
-      key: {},
-      value: {get: row => prettify(row.value)},
-    });
-    this.log();
+    // get args and flags
+    const {argv, flags} = await this.parse(PluginInfo);
+    // get needed helpers things
+    const {hyperdrive, app, context} = this.config;
+    // get the correct classes
+    const Plugin = context.app ? app.Plugin : hyperdrive.Plugin;
+
+    // try to get the info
+    try {
+      const result = await Plugin.info(argv[0]);
+
+      // if this isnt all then truncate the info to the bare essentials
+      const info = flags.all ? result : {
+        name: result.name,
+        description: result.description,
+        version: result.version,
+        author: result.author,
+        contributors: result.maintainers,
+        lando: result.lando,
+        repository: result.repository,
+      };
+
+      // if we have JSON then just return what we have
+      if (flags.json) return info;
+
+      // otherwise construct some rows for tabular display
+      const Config = context.app ? app.Config : hyperdrive.Config;
+      const rows = Config.keys(info, {expandArrays: false}).map(key => ({key, value: get(info, key)}));
+      // construct the column options
+      const columns = {key: {}, value: {get: row => prettify(row.value)}};
+
+      // print table
+      this.log();
+      CliUx.ux.table(rows, columns, {extended: flags.extended});
+      this.log();
+
+    // if we cannot get info then throw an error here
+    } catch (error) {
+      this.error(error);
+    }
   }
 }
 

components/minapp.js

@@ -58,7 +58,9 @@ class MinApp {
     const mainfile = yaml.parse(fs.readFileSync(landofile, 'utf8'));
     this.name = slugify(mainfile.name, {lower: true, strict: true});
     this.root = path.dirname(landofile);
+    Config.id = this.name;
     Plugin.id = this.name;
+    this.Config = Config;
     this.Plugin = Plugin;
 
     // set other props that are name-dependent

core/bootstrap.js

@@ -36,10 +36,11 @@ class Bootstrapper {
     this.registry = options.registry || {};
 
     // add some helper classes
+    Config.id = this.id;
     Plugin.id = this.id;
-    this.Plugin = Plugin;
     this.Bootstrapper = Bootstrapper;
     this.Config = Config;
+    this.Plugin = Plugin;
   }
 
   // @TODO: the point of this is to have a high level way to "fetch" a certain kind of plugin eg global and

core/config.js

@@ -18,6 +18,8 @@ nconf.formats.yaml = {
  * Creates a new Config instance.
  */
 class Config extends nconf.Provider {
+  static id = 'lando';
+
   static keys(data, {prefix = '', expandArrays = true} = {}) {
     return require('../utils/get-object-keys')(data, {prefix, expandArrays});
   }
@@ -26,7 +28,7 @@ class Config extends nconf.Provider {
     // get parent stuff
     super();
     // get the id first since we need this for downstream things
-    this.id = options.id || options.product || path.basename(process.argv[1]);
+    this.id = options.id || options.product || path.basename(process.argv[1]) || Config.id;
     // properties
     this.managed = options.managed || 'managed';
     // namespaces utils