Skip to content

Commit ce675c6

Browse files
committed
Refactor Router error handling
1 parent 543f47b commit ce675c6

File tree

1 file changed

+7
-14
lines changed

1 file changed

+7
-14
lines changed

Diff for: server.js

+7-14
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ program
2626

2727
.option('--handler <path>', 'Lambda@Edge handler script.')
2828
.option('--port <number>', 'HTTP server port number.', SERVER_PORT)
29-
.option('--silent', 'Disable logging events to STDOUT')
29+
.option('--silent', 'Disable logging Router errors to STDOUT', false)
3030

3131
.action(function(opts) {
3232
const errors = [];
@@ -84,14 +84,14 @@ if (process.env.NODE_ENV === 'test') {
8484
* @param {Function} port
8585
* HTTP server port number.
8686
*
87-
* @param {Boolean} logEvents
88-
* Log events to STDOUT (default: true).
87+
* @param {Boolean} logRouterError
88+
* Log Router errors to STDOUT (default: true).
8989
*
9090
* @return {Object}
9191
*
9292
* @see https://docs.aws.amazon.com/lambda/latest/dg/nodejs-handler.html
9393
*/
94-
function initServer(handler, port, logEvents = true) {
94+
function initServer(handler, port, logRouterError = true) {
9595
const server = http.createServer(function(req, res) {
9696
let body = '';
9797

@@ -167,28 +167,21 @@ function initServer(handler, port, logEvents = true) {
167167
log(Date.now(), req.method, path, JSON.stringify(event));
168168

169169
} catch (err) {
170-
this.emit('error', Error('Malformed handler method. Exiting..'));
170+
logRouterError && this.emit('error', err);
171171
}
172172
});
173173
});
174174

175-
// Log event to STDOUT.
176-
const log = function() {
177-
if (logEvents) {
178-
console.log(...arguments);
179-
}
180-
};
181-
182175
// Start HTTP server; increment port if used.
183176
return server
184177
.listen(port, () => {
185-
log(`HTTP server started. Listening on port ${port}`);
178+
console.info(`HTTP server started. Listening on port ${port}`);
186179
})
187180
.on('error', function(err) {
188181
if (err.code === 'EADDRINUSE') {
189182
this.close();
190183

191-
log(`Port ${port} in use. Trying another port.`);
184+
console.error(`Port ${port} in use. Trying another port.`);
192185

193186
initServer(handler, port + 1);
194187
}

0 commit comments

Comments
 (0)