Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init: argument list too long #5621

Open
vsukhin opened this issue Jun 29, 2024 · 5 comments
Open

init: argument list too long #5621

vsukhin opened this issue Jun 29, 2024 · 5 comments
Labels
Bug Created by Linear-GitHub Sync

Comments

@vsukhin
Copy link
Collaborator

vsukhin commented Jun 29, 2024

Describe the bug
Argument list is too long for Test Workflow init with multiple and big env

To Reproduce
Steps to reproduce the behavior:

  1. Create test workflow
  2. Specify env var with big sizes like cert or so
  3. See error
    exec /.tktw/init: argument list too long
    Aborted (Error)
    Error

Expected behavior
Test Workflow is executed without error

Version / Cluster

  • Which testkube version? 2.0.2
  • What Kubernetes cluster?Minikube
  • What Kubernetes version? 1.25
@vsukhin vsukhin added the bug 🐛 Something is not working as should be label Jun 29, 2024
@linear linear bot added Bug Created by Linear-GitHub Sync and removed bug 🐛 Something is not working as should be labels Jul 2, 2024
@rangoo94
Copy link
Member

rangoo94 commented Jul 3, 2024

@vsukhin, are you sure that it's about the environment variable, not just the long argument? The certificate is actually passed as an argument to the Toolkit, and I would rather say that it's directly related to the script itself.

Two things to fix:

  • Read the certificate and token for clone operation from env variables directly, not CLI parameters (direct issue)
  • When there is a big shell script to run, extract it to a separate file (similar issue)

I think that the latter one can be delayed for now, as it's edge case too, and we can just fix the direct issue

@vsukhin
Copy link
Collaborator Author

vsukhin commented Jul 3, 2024

Yes, then it's about direct issue. User can provide additional details https://testkubeworkspace.slack.com/archives/C06DD6RUWAZ/p1719555213306649

@rangoo94
Copy link
Member

rangoo94 commented Jul 3, 2024

Actually, seems like environment variables also contribute to this size: https://stackoverflow.com/questions/28865473/setting-environment-variable-to-a-large-value-argument-list-too-long. Then, big data like certificates will need to be passed via files.

For the direct issue, it shouldn't be a problem anyway I guess.

@vsukhin
Copy link
Collaborator Author

vsukhin commented Jul 3, 2024

interesting

@vsukhin
Copy link
Collaborator Author

vsukhin commented Jul 4, 2024

should we close it by adding notes to documentation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

2 participants