Merge pull request #3935 from cpanato/fix

fix array size when creating the assets

Author: k8s-ci-robot

cmd/publish-release/cmd/github.go

@@ -308,13 +308,14 @@ func runGithubPage(opts *githubPageCmdLineOptions) (err error) {
 		}
 	}
 
-	newAssets := make([]string, len(assets)+1)
-	for i, a := range assets {
-		newAssets[i] = a.ReadFrom
+	var newAssets []string //nolint: prealloc,gocritic
+	for _, a := range assets {
+		newAssets = append(newAssets, a.ReadFrom)
 	}
-
 	// add sbom to the path to upload
-	newAssets[len(assets)] = sbomStr
+	if sbomStr != "" {
+		newAssets = append(newAssets, sbomStr)
+	}
 
 	// Build the release page options
 	ghOpts := github.Options{

pkg/announce/github/impl.go

@@ -49,6 +49,10 @@ func (i *defaultImpl) github() *githubsdk.GitHub {
 func (i *defaultImpl) processAssetFiles(assetFiles []string) (releaseAssets []map[string]string, err error) {
 	// Check all asset files and get their hashes
 	for _, path := range assetFiles {
+		if path == "" {
+			continue
+		}
+
 		assetData := map[string]string{
 			"rawpath": path,
 			"name":    "",