Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update nodejs in GHActions #9354

Closed
longwuyuan opened this issue Dec 1, 2022 · 8 comments · Fixed by #9401
Closed

update nodejs in GHActions #9354

longwuyuan opened this issue Dec 1, 2022 · 8 comments · Fixed by #9401
Assignees
@SaumyaBhushan
Labels
area/stabilization Work for increasing stabilization of the ingress-nginx codebase good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@longwuyuan
Copy link
Contributor

longwuyuan commented Dec 1, 2022 •
edited
Loading

What happened:

Helm chart (v1.25.3)
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/ . Please update the following actions to use Node.js 16: engineerd/setup-kind@aa272fe

/triage accepted
/area stabilization

cc @strongjz @rikatz @tao12345666333
@longwuyuan longwuyuan added the kind/bug Categorizes issue or PR as related to a bug. label Dec 1, 2022
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. area/stabilization Work for increasing stabilization of the ingress-nginx codebase needs-priority labels Dec 1, 2022
@tao12345666333 tao12345666333 added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Dec 1, 2022
@tao12345666333
Copy link
Member

I have submitted a PR to upstream, after merged, we can update the version of this action
engineerd/setup-kind#211

@longwuyuan
Copy link
Contributor Author

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority labels Dec 1, 2022
@SaumyaBhushan
Copy link
Contributor

/assign

@SaumyaBhushan
Copy link
Contributor

Hi @tao12345666333 Have you already updated the version already or Can I do that ?

@tao12345666333
Copy link
Member

tao12345666333 commented Dec 1, 2022 •
edited
Loading

@SaumyaBhushan please see my comment #9354 (comment)

you should wait for the PR been merged before you try to update the action's version

@SaumyaBhushan
Copy link
Contributor

Sure thanks @tao12345666333

@longwuyuan
Copy link
Contributor Author

longwuyuan commented Dec 6, 2022 •
edited
Loading

@SaumyaBhushan if you have checked the status of the upstream PR that @tao12345666333 mentioned, then please link that PR here for tracking. If not, then please sync with Jintao and find out which PR in which repo etc etc and then link it here. Thank you

@SaumyaBhushan
Copy link
Contributor

@longwuyuan engineerd/setup-kind#211

@SaumyaBhushan SaumyaBhushan mentioned this issue Dec 6, 2022
Open
@tao12345666333 tao12345666333 mentioned this issue Dec 12, 2022
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SaumyaBhushan SaumyaBhushan

Labels
area/stabilization Work for increasing stabilization of the ingress-nginx codebase good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: remove setup-kind step tao12345666333/ingress-nginx
4 participants
@tao12345666333 @longwuyuan @k8s-ci-robot @SaumyaBhushan