Container Stop Signals

[sreeram-venkitesh]

Enhancement Description

• One-line enhancement description (can be used as a release note): Add support to configure custom stop signals for containers
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/4960-container-stop-signals/README.md
• Discussion Link: Add support for custom stop signal to send to containers kubernetes#30051
• Primary contact (assignee): @sreeram-venkitesh
• Responsible SIGs: sig-node
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): v1.33
  • Beta release target (x.y):
  • Stable release target (x.y):
• Alpha
  • KEP (k/enhancements) update PR(s): KEP 4960: Container Stop Signals #5122
  • Code (k/k) update PR(s): KEP 4960: Container Stop Signals kubernetes#130556
  • Docs (k/website) update PR(s): KEP 4960: Container Stop Signals website#49857

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[sreeram-venkitesh]

/sig node

[sreeram-venkitesh]

Related: kubernetes/kubernetes#128030. Will work on the KEP before v1.33.

[haircommander]

/label lead-opted-in
/milestone v1.33

[bianbbc87]

Hello @sreeram-venkitesh 👋, v1.33 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

This enhancement is targeting stage alpha for v1.33 (correct me, if otherwise)

Here’s where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: v1.33. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
• KEP readme has up-to-date graduation criteria.
• KEP has submitted a production readiness review request for approval and has a reviewer assigned.
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as Tracked for enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[sreeram-venkitesh]

Thanks @bianbbc87! I have #5122 open which is under review. I will update these in the same PR.

[bianbbc87]

@sreeram-venkitesh
Hi ! Please write the same PR to Alpha KEP later as well.

Thank you !

[dipesh-rawat]

Hi @sreeram-venkitesh 👋, 1.33 Enhancements team here,

Just a quick friendly reminder as we approach the enhancements freeze later this week, at 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

The current status of this enhancement is marked as At risk for enhancement freeze. There are a few requirements mentioned in the comment #4960 (comment) that still need to be completed.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

[sreeram-venkitesh]

@dipesh-rawat Thanks for the ping! The discussion around PRR is still going on in #5122, I'm hoping to get it merged before the freeze. #5122 should address all our requirements.

[sreeram-venkitesh]

@bianbbc87 @dipesh-rawat #5122 has been merged! PTAL!

[dipesh-rawat]

Hello @sreeram-venkitesh 👋, 1.33 Enhancements team here,

With PR #5122 has been merged, all the KEP requirements are in place and merged into k/enhancements.

Before the enhancement freeze, it would be appreciated if following nit could be addressed:

• Update issue description to add direct link to KEP README.md.

  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/4960-container-stop-signals/README.md

Aside from the minor nit mentioned above, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is now marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!
(cc: @bianbbc87)

/label tracked/yes

[sreeram-venkitesh]

Update issue #4960 (comment) to add direct link to KEP README.md.

Done.

[Urvashi0109]

Hello @sreeram-venkitesh 👋, v1.33 Docs Shadow here.

Does this enhancement work planned for v1.33 require any new docs or modification to existing docs?

If so, please follow the steps here to open a PR against dev-1.33 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 27th February 2025 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[sreeram-venkitesh]

@Urvashi0109: Docs placeholder PR opened: kubernetes/website#49857

[aakankshabhende]

Hi @sreeram-venkitesh 👋 -- this is Aakanksha (@aakankshabhende ) from the 1.33 Communications Team!

For the 1.33 release, we are currently in the process of collecting and curating a list of potential feature blogs, and we'd love for you to consider writing one for your enhancement!

As you may be aware, feature blogs are a great way to communicate to users about features which fall into (but not limited to) the following categories:

• This introduces some breaking change(s)
• This has significant impacts and/or implications to users
• ...Or this is a long-awaited feature, which would go a long way to cover the journey more in detail 🎉

To opt in to write a feature blog, could you please let us know and open a "Feature Blog placeholder PR" (which can be only a skeleton at first) against the website repository by Wednesday, 5th March, 2025? For more information about writing a blog, please find the blog contribution guidelines 📚

Tip

Some timeline to keep in mind:

• 02:00 UTC Wednesday, 5th March, 2025: Feature blog PR freeze
• Monday, 7th April, 2025: Feature blogs ready for review
• You can find more in the release document

Note

In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

[sreeram-venkitesh]

Hi @aakankshabhende! Thanks for reaching out. I'd like to opt in for a blog post and I've opened kubernetes/website#49967 as a placeholder PR for the blog.

[bianbbc87]

Hey again @sreeram-venkitesh 👋, v1.33 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025.

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PRs are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

• KEP 4960: Container Stop Signals kubernetes#130556

Additionally, please let me know if there are any other PRs in k/k not listed above that we should track for this KEP, so that we can maintain accurate status.

If you anticipate missing code freeze, you can file an exception request in advance.

As always, we are here to help if any questions come up. Thanks!

[sreeram-venkitesh]

@bianbbc87: I've opened kubernetes/kubernetes#130556 for the code PR. Its WIP right now.

[dipesh-rawat]

Hi @sreeram-venkitesh 👋, v1.33 Enhancements team here,

Just a quick friendly reminder as we approach the code freeze later this week, at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025.

The current status of this enhancement is marked as At risk for code freeze. There are a few requirements mentioned in the comment #4960 (comment) that still need to be completed.

If you anticipate missing code freeze, you can file an exception request in advance. Thank you!

[sreeram-venkitesh]

Thanks @dipesh-rawat! The PR is still undergoing review. I will talk with SIG Node folks and see if I can do an early exception if we are expecting it to take more time. I'll have this by Thursday before the code freeze so I can keep you folks in the loop. Thanks!

[dipesh-rawat]

Hello @sreeram-venkitesh 👋, v1.33 Enhancements team here,

Unfortunately, the implementation (code-related) PRs associated with this enhancement are not in the merge-ready state by code-freeze and hence this enhancement is now removed from the v1.33 milestone.

An exception request has been received (https://groups.google.com/g/kubernetes-sig-release/c/hBaNSMGXkq8) and is currently under evaluation. During this review period, the milestone has been removed. Depending on whether the request is approved or rejected, the milestone will be re-added accordingly. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks!

/milestone clear

[dipesh-rawat]

Hello @sreeram-venkitesh 👋, v1.33 Enhancements team here,

The release team has APPROVED the exception request here, so this KEP can now be considered to be added back to the v1.33 milestone. The updated deadline to merge all related PRs is 9:00 PDT on Monday, 24th March 2025.

If you have any questions, feel free to reach out in the Exception Request thread for this KEP on Slack in the #sig-release channel - we’re happy to help. Also, once the code PRs are merged, please feel free to let us know here. Once the PRs are merged, the milestone will be re-added accordingly.
Thanks!

[dipesh-rawat]

@sreeram-venkitesh With implementation PR kubernetes/kubernetes#130556 merged. This enhancement is now marked as tracked for code freeze for the v1.33 release!

/milestone v1.33