[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tasdikrahman
Once this PR has been reviewed and has the lgtm label, please assign gjtempleton for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Welcome @tasdikrahman!

It looks like this is your first PR to kubernetes-sigs/karpenter 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/karpenter has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

Hi @tasdikrahman. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Hey @tasdikrahman, as I recall, we wanted to start off with a small design before continuing with this. Was there anyone you had talked to about this while I was on vacation? If not, let's see if we can sync up and get a design in this PR. This should help align us on naming and making sure we're considering how this impacts any other controllers in the project.

I added the needs-design label that we can remove once we add the design into the PR.

I wonder if it would be better to start off with a quick design doc for RFC? This is adding a new controller and method of disruption. I am not fully sure how this fits in with other methods

Hey folks, sorry for the delay, I will work on sharing a design doc first on this and share it here to align on the approach and changes. I opened the PR as a wip. @njtran @garvinp-stripe @jonathan-innis

Thanks. @tasdikrahman I'll set this as a Draft in the meantime.

Hey @tasdikrahman how are you doing? Happy to keep you assigned if you want, but want to make sure that you're making progress. I want to make sure the issue is tracked properly based on if you're getting progress here.

/assign @njtran

/assign @jigisha620

@jonathan-innis: GitHub didn't allow me to assign the following users: jigisha620.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

/assign @jigisha620

@tasdikrahman hey, it seems like it's been a while since you've been able to work on this. I'll close this out and unassign you from the issue so someone else can take it up if they want, but feel free to take it up when you have more time.