Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved visibility on pod failing to schedule #927

Closed
wants to merge 7 commits into from
Closed

Improved visibility on pod failing to schedule #927

wants to merge 7 commits into from

Conversation

sadath-12
Copy link
Contributor

@sadath-12 sadath-12 commented Jan 7, 2024 •
edited
Loading

Fixes #686

Description

before this pr the error message would contain

karpenter/karpenter-9d8575fb-hmrf7[controller]: 2023-07-24T09:45:37.841Z	ERROR	controller.provisioner	Could not schedule pod, incompatible with provisioner "arm", did not tolerate arch=arm64:NoSchedule; incompatible with provisioner "x86", no instance type satisfied resources {"cpu":"16","memory":"32Gi","pods":"1"} and requirements karpenter.k8s.aws/instance-category In [c m r], karpenter.k8s.aws/instance-generation Exists >3, karpenter.k8s.aws/instance-hypervisor In [nitro], kubernetes.io/os In [linux], karpenter.sh/capacity-type In [on-demand], kubernetes.io/arch In [amd64], karpenter.sh/provisioner-name In [x86]	{"commit": "dc3af1a", "pod": "canda/canda-avstock-7bbc89bb7b-8t9lk"}```

after this pr the error message would

karpenter/karpenter-9d8575fb-hmrf7[controller]: 2023-07-24T09:45:37.841Z	ERROR	controller.provisioner	Could not schedule pod, incompatible with provisioner "arm", did not tolerate arch=arm64:NoSchedule; incompatible with provisioner "x86", required resource cpu 100m is greater than total resource cpu 50m"

How was this change tested?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sadath-12
optimize error msgs
d69d423 
Signed-off-by: sadath-12 <[email protected]>
@sadath-12
formatting
10f0ebf 
Signed-off-by: sadath-12 <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sadath-12
Once this PR has been reviewed and has the lgtm label, please assign jonathan-innis for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 7, 2024
@sadath-12
lint fix
d329338 
Signed-off-by: sadath-12 <[email protected]>
@tzneal
Copy link
Contributor

tzneal commented Jan 7, 2024

Can you include before & after messages to show what has changed in the visible output?

@sadath-12
Copy link
Contributor Author

sadath-12 commented Jan 8, 2024 •
edited
Loading

Can you include before & after messages to show what has changed in the visible output?

ya included in description

@sadath-12
minorfix
c1db97a 
Signed-off-by: sadath-12 <[email protected]>
@sadath-12
make verify
eca9d03 
Signed-off-by: sadath-12 <[email protected]>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7472371558

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 80.157%
Totals Coverage Status
Change from base Build 7465401143: 0.01%
Covered Lines: 7639
Relevant Lines: 9530
💛 - Coveralls

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions GitHub Actions
Copy link

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 27, 2024
@github-actions github-actions bot closed this Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzneal tzneal tzneal left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@jmdeal jmdeal Awaiting requested review from jmdeal

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/closed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve error messages if resource limit is reached
4 participants
@sadath-12 @k8s-ci-robot @tzneal @coveralls