Test Coverage for Metrics

[jonathan-innis]

Tell us about your request

Right now, we don't have anything validating our karpenter_cloudprovider_duration or karpenter_cloudprovider_errors_total metric that would ensure that we are actually firing the metric when we expect to. We should add unit testing, using the FindMetricsWithLabelValues function to ensure that we are getting these metrics.

We should audit and do this for all the following folders and audit any folders in other Cloud provider repos as well.

• pkg/cloudprovider/metrics
• pkg/metrics
• pkg/controllers/metrics
• pkg/controllers/termination/terminator/metrics.go
• pkg/controllers/provisioning/metrics.go
• /pkg/controllers/consistency/metrics.go
• /pkg/controllers/deprovisioning/metrics.go

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?

N/A

Are you currently working around this issue?

N/A

Additional Context

No response

Attachments

No response

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment