Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align documentation about HTTPRouteTimeouts.BackendRequest timeout scope #3462

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Align documentation about HTTPRouteTimeouts.BackendRequest timeout scope #3462

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65d5bf4
fix: align backend timeout documentation, and Traefik timeouts sequen…
rtribotte Nov 20, 2024
1e4b826
align the sequence diagram with go doc
rtribotte Feb 18, 2025
7e53a74
review
rtribotte Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions geps/gep-1742/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,15 +270,15 @@ sequenceDiagram
Note right of P: respondingTimeouts<br/>readTimeout
C->>P: Finishes request
deactivate P
P->>U: Connection Started
activate U
P->>U: Connection Started
Note right of U: forwardingTimeouts<br/>dialTimeout
deactivate U
activate U
P->>U: Starts sending Request
P->>U: Finishes request
P->>U: Finishes Headers
U->>P: Starts Response
activate U
note right of U: forwardingTimeouts<br/>responseHeaderTimeout
U->>P: Finishes Headers
deactivate U
Expand Down Expand Up @@ -357,9 +357,9 @@ sequenceDiagram
P->>U: Finishes Headers
U->>P: Starts Response
U->>P: Finishes Headers
note right of P: timeouts.backendRequest end time
note left of P: timeouts.request end time
U->>P: Finishes Response
note right of P: timeouts.backendRequest end time
note right of P: Repeat if retry
P->>C: Starts Response
P->>C: Finishes Headers
Expand Down Expand Up @@ -418,7 +418,7 @@ type HTTPRouteTimeouts struct {

// BackendRequest specifies a timeout for an individual request from the gateway
// to a backend. This covers the time from when the request first starts being
// sent from the gateway to when the full response has been received from the backend.
// sent from the gateway to when the response headers have been received from the backend.
//
// An entire client HTTP transaction with a gateway, covered by the Request timeout,
// may result in more than one call from the gateway to the destination backend,
Expand Down