-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate Images for Light and Dark Mode #3146
Comments
/help |
@robscott: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign |
Hi @robscott , I've checked the images, and it's a lot to process by myself, so it's going to take a while. How about turning this into an umbrella issue and working with contributors to change it? |
@jongwooo Sorry I missed this one! If you want to make smaller PRs to just update some of the images, that would be great. I don't think that strictly requires separate/smaller issues, but if you want to create smaller issues, that's also great. Thanks again for the help on this! |
What would you like to be added:
As a prerequisite for #2896 to be merged, we'll need to introduce separate images for light and dark mode. This can be done by either converting diagrams to mermaid.js, or creating equivalent dark mode images and following the documentation to specify the mode they're intended to be used with.
Why this is needed:
It would be very helpful to have light and dark mode for our docs, but unfortunately our current documentation relies on images that don't work well in dark mode. This work would unblock dark mode capabilities for our documentation.
The text was updated successfully, but these errors were encountered: