Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Request Timeouts for GRPCRoute #3139

Open
arkodg opened this issue Jun 7, 2024 · 5 comments
Open

Support Request Timeouts for GRPCRoute #3139

arkodg opened this issue Jun 7, 2024 · 5 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@arkodg
Copy link
Contributor

arkodg commented Jun 7, 2024

What would you like to be added:

A request.Timeout field within GRPCRoute similar to the one added in HTTPRoute as part of https://gateway-api.sigs.k8s.io/geps/gep-1742/

Why this is needed:

  1. Set a request timeout for unary rpc, that may vary from the default timeout of the implementation
  2. Disable timeouts (set to 0s) for streaming rpc
@arkodg arkodg added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 7, 2024
@arkodg
Copy link
Contributor Author

arkodg commented Jun 7, 2024

cc @robscott @frankbu @gnossen

@robscott
Copy link
Member

robscott commented Jun 8, 2024

Good call @arkodg! I think this one should be relatively straightforward, but because it's a new API field in a GA resource, we'll likely need to track it with a separate GEP. Do you mind adding this to #3103 if you think you'd have time to lead this in v1.2?

@arkodg
Copy link
Contributor Author

arkodg commented Jun 8, 2024

sure @robscott done

@robscott robscott added this to the v1.2.0 milestone Jun 11, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 9, 2024
@youngnick
Copy link
Contributor

This is still in progress, and may be in scope for 1.3.

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 11, 2024
@youngnick youngnick modified the milestones: v1.2.0, v1.3.0 Sep 11, 2024
@shaneutt shaneutt added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Sep 18, 2024
@shaneutt shaneutt moved this to In Progress in Gateway API Pipeline Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: In Progress
Development

No branches or pull requests

6 participants