Skip to content

Commit

Permalink
fix: align backend timeout documentation, and Traefik timeouts sequen…
Browse files Browse the repository at this point in the history
…ce diagram
  • Loading branch information
rtribotte committed Feb 18, 2025
1 parent d936258 commit 65d5bf4
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion apis/openapi/zz_generated.openapi.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apis/v1/httproute_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ type HTTPRouteTimeouts struct {

// BackendRequest specifies a timeout for an individual request from the gateway
// to a backend. This covers the time from when the request first starts being
// sent from the gateway to when the full response has been received from the backend.
// sent from the gateway to when the response headers have been received from the backend.
//
// Setting a timeout to the zero duration (e.g. "0s") SHOULD disable the timeout
// completely. Implementations that cannot completely disable the timeout MUST
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions config/crd/standard/gateway.networking.k8s.io_httproutes.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions geps/gep-1742/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -270,15 +270,15 @@ sequenceDiagram
Note right of P: respondingTimeouts<br/>readTimeout
C->>P: Finishes request
deactivate P
P->>U: Connection Started
activate U
P->>U: Connection Started
Note right of U: forwardingTimeouts<br/>dialTimeout
deactivate U
activate U
P->>U: Starts sending Request
P->>U: Finishes request
P->>U: Finishes Headers
U->>P: Starts Response
activate U
note right of U: forwardingTimeouts<br/>responseHeaderTimeout
U->>P: Finishes Headers
deactivate U
Expand Down Expand Up @@ -418,7 +418,7 @@ type HTTPRouteTimeouts struct {

// BackendRequest specifies a timeout for an individual request from the gateway
// to a backend. This covers the time from when the request first starts being
// sent from the gateway to when the full response has been received from the backend.
// sent from the gateway to when the response headers have been received from the backend.
//
// An entire client HTTP transaction with a gateway, covered by the Request timeout,
// may result in more than one call from the gateway to the destination backend,
Expand Down

0 comments on commit 65d5bf4

Please sign in to comment.