Skip to content

Commit 2bcf539

Browse files
kubermatic-botkron4eg
andauthoredDec 16, 2024
Use dedicated keyring for docker packages (#3486)
Signed-off-by: Artiom Diomin <[email protected]> Co-authored-by: Artiom Diomin <[email protected]>
1 parent 3aa836a commit 2bcf539

7 files changed

+42
-21
lines changed
 

‎pkg/scripts/render.go

+6-3
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,12 @@ var containerRuntimeTemplates = map[string]string{
5454
{{ if .CONFIGURE_REPOSITORIES }}
5555
sudo apt-get update
5656
sudo apt-get install -y apt-transport-https ca-certificates curl software-properties-common lsb-release
57-
curl -fsSL https://download.docker.com/linux/$(lsb_release -si | tr '[:upper:]' '[:lower:]')/gpg |
58-
sudo apt-key add -
59-
sudo add-apt-repository "deb https://download.docker.com/linux/$(lsb_release -si | tr '[:upper:]' '[:lower:]') $(lsb_release -cs) stable"
57+
sudo install -m 0755 -d /etc/apt/keyrings
58+
curl -fsSL https://download.docker.com/linux/ubuntu/gpg | sudo gpg --dearmor -o /etc/apt/keyrings/docker.gpg
59+
sudo chmod a+r /etc/apt/keyrings/docker.gpg
60+
61+
echo "deb [signed-by=/etc/apt/keyrings/docker.gpg] https://download.docker.com/linux/ubuntu $(lsb_release -cs) stable" | sudo tee /etc/apt/sources.list.d/docker.list
62+
sudo apt-get update
6063
{{ end }}
6164
6265
sudo apt-mark unhold containerd.io || true

‎pkg/scripts/testdata/TestKubeadmDebian-cilium_cluster.golden

+6-3
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,12 @@ kube_ver="1.30.0-*"
7878

7979
sudo apt-get update
8080
sudo apt-get install -y apt-transport-https ca-certificates curl software-properties-common lsb-release
81-
curl -fsSL https://download.docker.com/linux/$(lsb_release -si | tr '[:upper:]' '[:lower:]')/gpg |
82-
sudo apt-key add -
83-
sudo add-apt-repository "deb https://download.docker.com/linux/$(lsb_release -si | tr '[:upper:]' '[:lower:]') $(lsb_release -cs) stable"
81+
sudo install -m 0755 -d /etc/apt/keyrings
82+
curl -fsSL https://download.docker.com/linux/ubuntu/gpg | sudo gpg --dearmor -o /etc/apt/keyrings/docker.gpg
83+
sudo chmod a+r /etc/apt/keyrings/docker.gpg
84+
85+
echo "deb [signed-by=/etc/apt/keyrings/docker.gpg] https://download.docker.com/linux/ubuntu $(lsb_release -cs) stable" | sudo tee /etc/apt/sources.list.d/docker.list
86+
sudo apt-get update
8487

8588

8689
sudo apt-mark unhold containerd.io || true

‎pkg/scripts/testdata/TestKubeadmDebian-nutanix_cluster.golden

+6-3
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,12 @@ kube_ver="1.30.0-*"
8181

8282
sudo apt-get update
8383
sudo apt-get install -y apt-transport-https ca-certificates curl software-properties-common lsb-release
84-
curl -fsSL https://download.docker.com/linux/$(lsb_release -si | tr '[:upper:]' '[:lower:]')/gpg |
85-
sudo apt-key add -
86-
sudo add-apt-repository "deb https://download.docker.com/linux/$(lsb_release -si | tr '[:upper:]' '[:lower:]') $(lsb_release -cs) stable"
84+
sudo install -m 0755 -d /etc/apt/keyrings
85+
curl -fsSL https://download.docker.com/linux/ubuntu/gpg | sudo gpg --dearmor -o /etc/apt/keyrings/docker.gpg
86+
sudo chmod a+r /etc/apt/keyrings/docker.gpg
87+
88+
echo "deb [signed-by=/etc/apt/keyrings/docker.gpg] https://download.docker.com/linux/ubuntu $(lsb_release -cs) stable" | sudo tee /etc/apt/sources.list.d/docker.list
89+
sudo apt-get update
8790

8891

8992
sudo apt-mark unhold containerd.io || true

‎pkg/scripts/testdata/TestKubeadmDebian-with_containerd.golden

+6-3
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,12 @@ kube_ver="1.30.0-*"
7878

7979
sudo apt-get update
8080
sudo apt-get install -y apt-transport-https ca-certificates curl software-properties-common lsb-release
81-
curl -fsSL https://download.docker.com/linux/$(lsb_release -si | tr '[:upper:]' '[:lower:]')/gpg |
82-
sudo apt-key add -
83-
sudo add-apt-repository "deb https://download.docker.com/linux/$(lsb_release -si | tr '[:upper:]' '[:lower:]') $(lsb_release -cs) stable"
81+
sudo install -m 0755 -d /etc/apt/keyrings
82+
curl -fsSL https://download.docker.com/linux/ubuntu/gpg | sudo gpg --dearmor -o /etc/apt/keyrings/docker.gpg
83+
sudo chmod a+r /etc/apt/keyrings/docker.gpg
84+
85+
echo "deb [signed-by=/etc/apt/keyrings/docker.gpg] https://download.docker.com/linux/ubuntu $(lsb_release -cs) stable" | sudo tee /etc/apt/sources.list.d/docker.list
86+
sudo apt-get update
8487

8588

8689
sudo apt-mark unhold containerd.io || true

‎pkg/scripts/testdata/TestKubeadmDebian-with_containerd_with_insecure_registry.golden

+6-3
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,12 @@ kube_ver="1.30.0-*"
7878

7979
sudo apt-get update
8080
sudo apt-get install -y apt-transport-https ca-certificates curl software-properties-common lsb-release
81-
curl -fsSL https://download.docker.com/linux/$(lsb_release -si | tr '[:upper:]' '[:lower:]')/gpg |
82-
sudo apt-key add -
83-
sudo add-apt-repository "deb https://download.docker.com/linux/$(lsb_release -si | tr '[:upper:]' '[:lower:]') $(lsb_release -cs) stable"
81+
sudo install -m 0755 -d /etc/apt/keyrings
82+
curl -fsSL https://download.docker.com/linux/ubuntu/gpg | sudo gpg --dearmor -o /etc/apt/keyrings/docker.gpg
83+
sudo chmod a+r /etc/apt/keyrings/docker.gpg
84+
85+
echo "deb [signed-by=/etc/apt/keyrings/docker.gpg] https://download.docker.com/linux/ubuntu $(lsb_release -cs) stable" | sudo tee /etc/apt/sources.list.d/docker.list
86+
sudo apt-get update
8487

8588

8689
sudo apt-mark unhold containerd.io || true

‎pkg/scripts/testdata/TestUpgradeKubeadmAndCNIDebian.golden

+6-3
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,12 @@ sudo apt-mark unhold kubelet kubeadm kubectl kubernetes-cni cri-tools
7979

8080
sudo apt-get update
8181
sudo apt-get install -y apt-transport-https ca-certificates curl software-properties-common lsb-release
82-
curl -fsSL https://download.docker.com/linux/$(lsb_release -si | tr '[:upper:]' '[:lower:]')/gpg |
83-
sudo apt-key add -
84-
sudo add-apt-repository "deb https://download.docker.com/linux/$(lsb_release -si | tr '[:upper:]' '[:lower:]') $(lsb_release -cs) stable"
82+
sudo install -m 0755 -d /etc/apt/keyrings
83+
curl -fsSL https://download.docker.com/linux/ubuntu/gpg | sudo gpg --dearmor -o /etc/apt/keyrings/docker.gpg
84+
sudo chmod a+r /etc/apt/keyrings/docker.gpg
85+
86+
echo "deb [signed-by=/etc/apt/keyrings/docker.gpg] https://download.docker.com/linux/ubuntu $(lsb_release -cs) stable" | sudo tee /etc/apt/sources.list.d/docker.list
87+
sudo apt-get update
8588

8689

8790
sudo apt-mark unhold containerd.io || true

‎pkg/scripts/testdata/TestUpgradeKubeletAndKubectlDebian.golden

+6-3
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,12 @@ sudo apt-mark unhold kubelet kubeadm kubectl kubernetes-cni cri-tools
7979

8080
sudo apt-get update
8181
sudo apt-get install -y apt-transport-https ca-certificates curl software-properties-common lsb-release
82-
curl -fsSL https://download.docker.com/linux/$(lsb_release -si | tr '[:upper:]' '[:lower:]')/gpg |
83-
sudo apt-key add -
84-
sudo add-apt-repository "deb https://download.docker.com/linux/$(lsb_release -si | tr '[:upper:]' '[:lower:]') $(lsb_release -cs) stable"
82+
sudo install -m 0755 -d /etc/apt/keyrings
83+
curl -fsSL https://download.docker.com/linux/ubuntu/gpg | sudo gpg --dearmor -o /etc/apt/keyrings/docker.gpg
84+
sudo chmod a+r /etc/apt/keyrings/docker.gpg
85+
86+
echo "deb [signed-by=/etc/apt/keyrings/docker.gpg] https://download.docker.com/linux/ubuntu $(lsb_release -cs) stable" | sudo tee /etc/apt/sources.list.d/docker.list
87+
sudo apt-get update
8588

8689

8790
sudo apt-mark unhold containerd.io || true

0 commit comments

Comments
 (0)