[#26] Ability to disable and enable colouring #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hint-man[bot]](https://avatars.githubusercontent.com/in/20170?s=60&v=4){kind=small}
vrom911
reviewed
Aug 23, 2020
There was a problem hiding this comment.
Wow, this is some kind of magic 🧙🏼♂️
I really like how simple the functions still look!
I agree, that we should move in into a separate module.
Also, regarding the docs, I think that it would be helpful to have:
- Migration guides (even if you don't need to change anything, I still think it should be added explicitly)
- Explanation on how implicit params work, what does
?mean there and some links to the docs would be awesome - Also updated README and
.cabalfile description with the note about this feature and probably example?
Generally, that is a really fantastic feature, and you come up with am awesome solution 👏🏼 ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #26
Implemented using Implicit parameters. Verified in GHCi that it works!
Ideally, all existing code that uses
colouristacan simply upgrade to the latest version and it should work without any changes. If users want to support disabling and enabling of colouring, they need to add explicitHasColourModeconstraint. Currently, we have a magic instance that automatically sets colour mode toEnableColour. But in the future, we can remove it, once users migrate to this new version, so we can have compile-time guarantees on making sure this constraint is enabled.Open questions (and possible TODOs):
ColourModeinto a separate module likeColourista.Mode?