Typo causing crash on Waylnd compositors that dont support xdg-toplevel-icon

kovidgoyal · kovidgoyal · commit 2c0bc79be14a · 2025-03-24T14:23:32.000+05:30
Fix #8471
diff --git a/docs/changelog.rst b/docs/changelog.rst
@@ -118,6 +118,10 @@ Detailed list of changes
   applications that dont specify a destination in the escape code not working
   (:iss:`8459`)
 
+- Wayland: Fix a regression in the previous release that caused crashes on
+  compositors that dont support the xdg-toplevel-icon protocol and the user has
+  set a custom kitty icon (:iss:`8471`)
+
 0.40.1 [2025-03-18]
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
diff --git a/glfw/wl_window.c b/glfw/wl_window.c
@@ -1474,6 +1474,7 @@ _glfwPlatformSetWindowIcon(_GLFWwindow* window, int count, const GLFWimage* imag
             _glfwInputError(GLFW_FEATURE_UNAVAILABLE, "Wayland: The compositor does not support changing window icons");
             warned_once = true;
         }
+        return;
     }
     if (!count) {
         xdg_toplevel_icon_manager_v1_set_icon(_glfw.wl.xdg_toplevel_icon_manager_v1, window->wl.xdg.toplevel, NULL);

Original file line number	Diff line number	Diff line change
`@@ -1474,6 +1474,7 @@ _glfwPlatformSetWindowIcon(_GLFWwindow* window, int count, const GLFWimage* imag`
`1474`	`1474`	`_glfwInputError(GLFW_FEATURE_UNAVAILABLE, "Wayland: The compositor does not support changing window icons");`
`1475`	`1475`	`warned_once = true;`
`1476`	`1476`	`}`
	`1477`	`+ return;`
`1477`	`1478`	`}`
`1478`	`1479`	`if (!count) {`
`1479`	`1480`	`xdg_toplevel_icon_manager_v1_set_icon(_glfw.wl.xdg_toplevel_icon_manager_v1, window->wl.xdg.toplevel, NULL);`