Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] CPUBurst cannot co-work with CPUNormalization #2306

Open
saintube opened this issue Dec 27, 2024 · 2 comments
Open

[BUG] CPUBurst cannot co-work with CPUNormalization #2306

saintube opened this issue Dec 27, 2024 · 2 comments
Labels
area/koordlet help wanted Extra attention is needed kind/bug Create a report to help us improve

Comments

@saintube
Copy link
Member

What happened:

Koordlet supports two features CPUBurst and CPUNormalization which can change the cpu.cfs_quota_us/cpu.max of the LS pods and containers. However, these features can not co-work for the cfs_quota adjustment. When both features are enabled, the QoS plugin of the CPUBurst modifies the cfs_quota due to the cfs throttled ratio of pods. In contrast, the runtime hook plugin of the CPUNormalization may overwrite the cfs_quota according to the CPU-normalisation ratio of the node. Then neither of them can achieve their reconciliation.

What you expected to happen:

To make the CPUBurst feature co-work with the CPUNormalization, the CPUBurst QoS plugin should be aware of the CPU-normalization ratio of the node. When both features are enabled, the CPUBurst QoS plugin is responsible for adjusting the cpu.cfs_quota_us/cpu.max according to the scaling ratio and the CPU-normalization ratio, and the runtime hook of the CPUNormalization should stop its reconciliation to avoid conflicts.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • App version: v1.5.0
  • Kubernetes version (use kubectl version):
  • Install details (e.g. helm install args):
  • Node environment (for koordlet/runtime-proxy issue):
    • Containerd/Docker version:
    • OS version:
    • Kernal version:
    • Cgroup driver: cgroupfs/systemd
  • Others:
@saintube saintube added help wanted Extra attention is needed area/koordlet kind/bug Create a report to help us improve labels Dec 27, 2024
@saintube
Copy link
Member Author

Hi @saintube I came across this issue and would like to work on resolving it. Could you please assign it to me?

OK.

@nakul-py nakul-py removed their assignment Dec 27, 2024
@nakul-py
Copy link

I cannot build or install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/koordlet help wanted Extra attention is needed kind/bug Create a report to help us improve
Projects
None yet
Development

No branches or pull requests

2 participants