Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default value of autoConnect & autoReconnect option #39

Open
usirin opened this issue Jun 7, 2017 · 0 comments
Open

Change default value of autoConnect & autoReconnect option #39

usirin opened this issue Jun 7, 2017 · 0 comments

Comments

@usirin
Copy link
Member

usirin commented Jun 7, 2017

I am finding myself to write new Kite({url: '...', autoConnect: false, autoReconnect: false}) all the time in following scenarios:

  • writing unit tests for kite
  • if i am initializing other objects other than kite as well, i want to have a preparation phase and want to call kite.connect() afterwards.
  • if i want to have a kite as a singleton e.g export default new Kite({ ... })

Having to write auto{Connect,Reconnect} all the time is a little bit tedious.

I would probably not need autoReconnect, since it's about connecting after disconnecting. But i still would expect from an object to connect something when i tell it to.

@gokmen I think this is good enough to be one of our breaking changes for moving forward to v2.

@usirin usirin added this to the 2.0.0 Release milestone Jun 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant