Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper way to add Subscription annotations #8501

Open
csc-piscopo opened this issue Feb 24, 2025 · 0 comments
Open

Proper way to add Subscription annotations #8501

csc-piscopo opened this issue Feb 24, 2025 · 0 comments

Comments

@csc-piscopo
Copy link

Looking for some guidance here on how to properly add annotations to a Subscription, any input would definitely be appreciated.

I am currently trying to add annotations like so to my subscription:

apiVersion: messaging.knative.dev/v1
kind: Subscription
metadata:
  name: seq-blah-sequence-0
  namespace: namespace-xyz
  annotations:
    autoscaling.eventing.knative.dev: "0"
    autoscaling.eventing.knative.dev/cooldown-period: "60"
    autoscaling.eventing.knative.dev/lag-threshold: "100"
    autoscaling.eventing.knative.dev/max-scale: "10"
    autoscaling.eventing.knative.dev/min-scale: "1"
    autoscaling.eventing.knative.dev/polling-interval: "60"

That works briefly until the eventing-controller comes along and stomps on those changes, removing all the custom annotations I have added.

Feels like I am missing something obvious with getting the KEDA autoscaling to work with the Subscription resource. Appreciate any insights!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant