Skip to content

Commit 2e6742c

Browse files
[release-1.13] Fix mtbroker-filter to proxy response headers (#7633)
* Fix mtbroker-filter to proxy response headers * Switch to utils.PassThroughHeaders --------- Co-authored-by: Christoph Stäbler <[email protected]>
1 parent fd95228 commit 2e6742c

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

pkg/broker/filter/filter_handler.go

+3-2
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,8 @@ func (h *Handler) writeResponse(ctx context.Context, writer http.ResponseWriter,
440440
writer.WriteHeader(http.StatusBadGateway)
441441
return http.StatusBadGateway, errors.New("received a non-empty response not recognized as CloudEvent. The response MUST be either empty or a valid CloudEvent")
442442
}
443-
writeHeaders(dispatchInfo.ResponseHeader, writer) // Proxy original Response Headers for downstream use
443+
444+
writeHeaders(utils.PassThroughHeaders(dispatchInfo.ResponseHeader), writer) // Proxy original Response Headers for downstream use
444445
h.logger.Debug("Response doesn't contain a CloudEvent, replying with an empty response", zap.Any("target", target))
445446
writer.WriteHeader(dispatchInfo.ResponseCode)
446447
return dispatchInfo.ResponseCode, nil
@@ -467,7 +468,7 @@ func (h *Handler) writeResponse(ctx context.Context, writer http.ResponseWriter,
467468
defer eventResponse.Finish(nil)
468469

469470
// Proxy the original Response Headers for downstream use
470-
writeHeaders(dispatchInfo.ResponseHeader, writer)
471+
writeHeaders(utils.PassThroughHeaders(dispatchInfo.ResponseHeader), writer)
471472

472473
if err := cehttp.WriteResponseWriter(ctx, eventResponse, dispatchInfo.ResponseCode, writer); err != nil {
473474
return http.StatusInternalServerError, fmt.Errorf("failed to write response event: %w", err)

0 commit comments

Comments
 (0)