Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document new configuration elements for Deployment resources #6096

Open
mgencur opened this issue Aug 13, 2024 · 4 comments
Open

Document new configuration elements for Deployment resources #6096

mgencur opened this issue Aug 13, 2024 · 4 comments

Comments

@mgencur
Copy link
Contributor

mgencur commented Aug 13, 2024

What is changing?

There are a few configuration elements which are not documented yet in this document:

        QueueSidecarTokenAudiences sets.Set[string]

	// QueueSidecarRootCA is a root certificate to be trusted by the queue proxy sidecar  qpoptions.
	QueueSidecarRootCA string

	// DefaultAffinityType is a string that controls what affinity rules will be automatically
	// applied to the PodSpec of all Knative services.
	DefaultAffinityType AffinityType

	// RuntimeClassNames specifies which runtime the Pod will use
	RuntimeClassNames map[string]RuntimeClassNameLabelSelector

As defined in the config in this section

How will this impact our users?

In what release will this take happen (to the best of your knowledge)?

release-1.14
release-1.15

Context

Link to associated PRs or issues from other repos here.

Additional info

@skonto
Copy link
Contributor

skonto commented Sep 18, 2024

cc @ReToCode QueueSidecar* are documented in internal encryption?

@ReToCode
Copy link
Member

That has nothing to do with internal encryption. I assume qpoptions is from https://github.com/knative-extensions/security-guard? @davidhadas

@skonto
Copy link
Contributor

skonto commented Sep 23, 2024

cc @dprotaso

@10sharmashivam
Copy link

Hi @ReToCode @skonto, I would like to work on documenting these new configuration elements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants