Issue checkstyle#4284: disallow junit.framework package in test code

Author: romani

config/ant-phase-verify.xml

@@ -35,6 +35,7 @@
       <property key="checkstyle.header.file" file="config/java.header"/>
       <property key="checkstyle.regexp.header.file" file="config/java_regexp.header"/>
       <property key="checkstyle.importcontrol.file" file="config/import-control.xml"/>
+      <property key="checkstyle.importcontroltest.file" file="config/import-control-test.xml"/>
       <property key="checkstyle.suppressions.file"
                 file="config/suppressions.xml"/>
     </checkstyle>

config/build.xml

@@ -37,6 +37,7 @@
       <property key="checkstyle.header.file" file="config/java.header"/>
       <property key="checkstyle.regexp.header.file" file="config/java_regexp.header"/>
       <property key="checkstyle.importcontrol.file" file="config/import-control.xml"/>
+      <property key="checkstyle.importcontroltest.file" file="config/import-control-test.xml"/>
       <property key="checkstyle.suppressions.file"
                 file="config/suppressions.xml"/>
     </checkstyle>

config/checkstyle_checks.xml

@@ -329,9 +329,15 @@
     </module>
     <module name="IllegalImport"/>
     <module name="ImportControl">
+      <property name="id" value="ImportControlMain"/>
       <property name="file" value="${checkstyle.importcontrol.file}"/>
       <property name="path" value="^.*[\\/]src[\\/]main[\\/].*$"/>
     </module>
+    <module name="ImportControl">
+      <property name="id" value="ImportControlTest"/>
+      <property name="file" value="${checkstyle.importcontroltest.file}"/>
+      <property name="path" value="^.*[\\/]src[\\/]test[\\/].*$"/>
+    </module>
     <module name="ImportOrder">
       <property name="groups" value="/^java\./,javax,org"/>
       <property name="ordered" value="true"/>

config/import-control-test.xml

@@ -0,0 +1,12 @@
+<?xml version="1.0"?>
+<!DOCTYPE import-control PUBLIC
+    "-//Puppy Crawl//DTD Import Control 1.3//EN"
+    "http://checkstyle.sourceforge.net/dtds/import_control_1_3.dtd">
+
+<import-control pkg="com.puppycrawl.tools.checkstyle">
+
+  <allow pkg=".*" regex="true" />
+
+  <disallow pkg="junit.framework" />
+
+</import-control>

config/suppressions.xml

@@ -28,7 +28,6 @@
     <suppress checks="NPathComplexity" files="[\\/]XdocsPagesTest\.java"/>
     <suppress checks="IllegalCatch" files="[\\/]internal[\\/].*[\\/]\w+Util\.java"/>
     <suppress checks="EmptyBlock" files=".*[\\/]src[\\/]test[\\/]"/>
-    <suppress checks="ImportControl" files=".*[\\/]src[\\/](test|it)[\\/]"/>
     <suppress checks="Javadoc" files=".*[\\/]src[\\/](test|it)[\\/]"/>
     <suppress checks="MagicNumber" files=".*[\\/]src[\\/](test|it)[\\/]"/>
     <suppress checks="AvoidStaticImport" files=".*[\\/]src[\\/](test|it)[\\/]"/>

src/test/java/com/puppycrawl/tools/checkstyle/internal/utils/ConfigurationUtil.java

@@ -41,6 +41,7 @@ public static Configuration loadConfiguration(String path) throws CheckstyleExce
         props.setProperty("checkstyle.header.file", "file");
         props.setProperty("checkstyle.regexp.header.file", "file");
         props.setProperty("checkstyle.importcontrol.file", "file");
+        props.setProperty("checkstyle.importcontroltest.file", "file");
 
         return loadConfiguration(path, props);
     }