Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git_path from config.yml not used #921

Open
mblythe86 opened this issue Nov 14, 2022 · 0 comments
Open

git_path from config.yml not used #921

mblythe86 opened this issue Nov 14, 2022 · 0 comments

Comments

@mblythe86
Copy link

I'm attempting to run gitlist on an ancient system where /usr/bin/git is version 1.7.1.

As a result, I'm getting an error unknown option 'short' when the code tries to call git symbolic-ref --short HEAD.

Since git_path is provided in the example config.yml, I assumed setting that would fix my issue, however, when I set it to the path of a more recent version of git, the error persists.

As far as I can tell, the git_path attribute in config.yml is unused. I'd expect src/SCM/System/Git/CommandLine.php to have some code to get the value from the config, but it doesn't. I also don't find anything in the ExecutableFinder class. I do see another reference to git_path in config/services.yml that seems to suggest that it is used to set $path, but it's not clear to me how this is supposed to work.

As a workaround, I manually set $path in the __construct function, and my errors have stopped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants