Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commits "Older" button pagination loads same page, not expected page #897

Open
dblume opened this issue Jan 15, 2022 · 1 comment
Open
Labels

Comments

@dblume
Copy link

dblume commented Jan 15, 2022

Gitlist 1.0 and 1.1 get the wrong page "appended".
Gitlist 2.0 loads the wrong page of commits, even with "?page=2".

Recipe

  1. Navigate to a project's "Commits" tab.
  2. See one page of commits with a "Older" button at the bottom.
  3. Click the "Older" button.

Expected Results

See the "next" page of commits.

Observed results

1.0, 1.1: The same page of commits already displayed gets appended (again).
2.0: New HTML page loaded with "?page=2" requested, but same page of commits retrieved.

Example Links (scroll down, click on "Older" button, observe wrong commits appear):

@dblume
Copy link
Author

dblume commented Jan 23, 2022

I just upgraded http://gitlist.dlma.com/testcode.git/commits/main from 1.1 to 2.0, and the "Older" button still doesn't do the expected thing. (The url gets "?page=2" added, but first page of commits is still retrieved.)

So this is a bug in both legacy version and the current version (as of 2.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants