Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: P2 controller input #21

Open
Hyphen-ated opened this issue Aug 26, 2022 · 4 comments
Open

Feature: P2 controller input #21

Hyphen-ated opened this issue Aug 26, 2022 · 4 comments

Comments

@Hyphen-ated
Copy link

The controller I use for rolling is different from the controller I use for DAS play (or for other NES games)

So I would find it convenient to be able to have two controllers always plugged in to my NES, and I pick up whichever one I want to use for tetris at any given time. So this would mean the game reads any input given on either controller port.

Are you interested in implementing this? If not I can try to do it myself, but I'm guessing you can probably do it kinda easily

@kirjavascript
Copy link
Owner

The thing to consider here is if we want to use the P2 input for something else in the future

support for mind meld and other two player modes have been suggested, which conflicts with this issue.

Additionally, this goes against the rules for CTM, where you are only allowed to have one input mapped to a single button.

at best we may be able to add a P1/P2 input toggle

@Hyphen-ated
Copy link
Author

CTM rules doesn't seem like a problem to me. They allow playing on an emulator on a PC, which has a similar capability to have two controllers active at once. You just aren't allowed to do it.

@kirjavascript
Copy link
Owner

Maybe. It's certainly a consideration for when thinking about cheating.

I suppose in mild meld (and other modes that use custom 2p stuff) there would need to be some kind of stuff to manage how the inputs are setup as we need support for different types of things.

@iwillreku3206
Copy link

Perhaps one way this could be implemented is the controller that presses "start" will be the only one that can register input in a game of Tetris?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants