Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Implement ControlValueAccessor for KirbyToggleButton #3790

Open
11 tasks
lydemann opened this issue Feb 17, 2025 · 0 comments · May be fixed by #3872
Open
11 tasks

[Enhancement] Implement ControlValueAccessor for KirbyToggleButton #3790

lydemann opened this issue Feb 17, 2025 · 0 comments · May be fixed by #3872
Assignees
Labels
enhancement New feature or request 👶🏻 New For new issues before prioritisation and refinement NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed

Comments

@lydemann
Copy link
Collaborator

Describe the enhancement

As the toggle button contains state it would be optimal for it to implement ControlValueAccessor so it can be used as a formControl in a reactive form.

Describe the solution you'd like

Implement ControlValueAccessor for the component.

Have you considered any alternatives?

Alternatives are to use the existing events to sync it with a formControl

Are there any additional context?


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Refinement

  • Request that the issue is UX refined
  • Request that the issue is tech refined; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

  • Make sure you have read: "Before you get coding".
  • Signal to others you are working on the issue by assigning yourself.
  • Create a branch from the develop branch following our branch naming convention.
  • Publish a WIP implementation to Github as a draft PR and ask for feedback.
  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Update the cookbook with examples and showcases.

Review

Once the issue has been implemented and is ready for review:

  • Do a self-review.
  • Create a pull-request. If you created a draft PR during implementation you can just mark that as "ready for review".
@lydemann lydemann added enhancement New feature or request NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed 👶🏻 New For new issues before prioritisation and refinement labels Feb 17, 2025
@github-project-automation github-project-automation bot moved this to 💌 Inbox in Kirby Feb 17, 2025
@RasmusKjeldgaard RasmusKjeldgaard moved this from 💌 Inbox to 📙 Backlog in Kirby Feb 24, 2025
@RasmusKjeldgaard RasmusKjeldgaard moved this from 📙 Backlog to 💌 Inbox in Kirby Feb 24, 2025
@RasmusKjeldgaard RasmusKjeldgaard moved this from 💌 Inbox to 📙 Backlog in Kirby Feb 24, 2025
@RasmusKjeldgaard RasmusKjeldgaard moved this from 📙 Backlog to 👀 Review In Progress in Kirby Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 👶🏻 New For new issues before prioritisation and refinement NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed
Projects
Status: 👀 Review In Progress
Development

Successfully merging a pull request may close this issue.

1 participant