Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] aria-label on kirby-radio-group is not forwarded to ion-radio-group #3795

Open
1 of 9 tasks
RasmusKjeldgaard opened this issue Feb 19, 2025 · 0 comments · May be fixed by #3814
Open
1 of 9 tasks

[BUG] aria-label on kirby-radio-group is not forwarded to ion-radio-group #3795

RasmusKjeldgaard opened this issue Feb 19, 2025 · 0 comments · May be fixed by #3814
Assignees
Labels
accessibility bug 👶🏻 New For new issues before prioritisation and refinement NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild

Comments

@RasmusKjeldgaard
Copy link
Collaborator

Describe the bug

Setting an aria-label on kirby-radio-group has no effect, as the form-control is actually the ion-radio-group within. We should take any aria-label attribute added to kirby-radio-group and set it on ion-radio-group instead.

Please note - we already have support for correct labelling when the radio group is used inside a form-field, so this is only for 'standalone' radio groups with aria-label attributes added.

Describe how to reproduce the bug

  1. Go to https://cookbook.kirby.design/branch/kby-develop/#/examples/radio
  2. Inspect the default radio-group and add an aria-label to the kirby-radio-group element
  3. Scan the page with e.g. level access extension
  4. See that the control is still missing an accessible name.

The proposed solution can be further validated by adding the label to ion-radio-group instead. Scanning again, the missing label error is now gone.

Which Kirby version was used?

10.3.0

What was the expected behavior?

Add any screenshots

Please complete the following information:

  • OS: [e.g. Windows, MacOS, iOS]
  • Browser [e.g. Chrome, Safari]
  • Browser version [e.g. 22]

Are there any additional context?


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Verification

To make sure the bug is not intended behaviour; it should be verified by a member of team Kirby before moving on to implementation.

  • Make sure the NOT verified label has been removed by a member of team Kirby; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

Review

Once the issue has been implemented and is ready for review:

@RasmusKjeldgaard RasmusKjeldgaard added bug NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild 👶🏻 New For new issues before prioritisation and refinement labels Feb 19, 2025
@github-project-automation github-project-automation bot moved this to 💌 Inbox in Kirby Feb 19, 2025
@RasmusKjeldgaard RasmusKjeldgaard moved this from 💌 Inbox to ⭐ Planned Work in Kirby Feb 24, 2025
@Fuzzy3 Fuzzy3 self-assigned this Feb 25, 2025
@Fuzzy3 Fuzzy3 moved this from ⭐ Planned Work to 🚀 In Progress in Kirby Feb 25, 2025
@Fuzzy3 Fuzzy3 linked a pull request Feb 27, 2025 that will close this issue
8 tasks
@Fuzzy3 Fuzzy3 moved this from 🚀 In Progress to 🔎 Review Pending in Kirby Feb 27, 2025
@Fuzzy3 Fuzzy3 moved this from 🔎 Review Pending to 👀 Review In Progress in Kirby Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug 👶🏻 New For new issues before prioritisation and refinement NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild
Projects
Status: 👀 Review In Progress
Development

Successfully merging a pull request may close this issue.

2 participants