Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ChoiceSpec usage to SharedPreferences #3

Open
kinnerapriyap opened this issue Jun 5, 2020 · 1 comment
Open

Move ChoiceSpec usage to SharedPreferences #3

kinnerapriyap opened this issue Jun 5, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@kinnerapriyap
Copy link
Owner

The library currently uses a kotlin version of a Builder implementation, but moving it to SharedPreferences would clean up access in the library itself.

Ref here and here
@kinnerapriyap kinnerapriyap added the enhancement New feature or request label Jun 5, 2020
@kinnerapriyap kinnerapriyap self-assigned this Jun 5, 2020
@kinnerapriyap
Copy link
Owner Author

  • Don't pollute the app's main SharedPreferences
  • Don't use the same keys as the app
  • Private unique SharedPreferences file, instead of getDefaultSharedPreferences().
    Link here

@kinnerapriyap kinnerapriyap removed their assignment Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kinnerapriyap