*: Add dedicated CRD helm chart #10828
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- helm create install/helm/kgateway-crds - Delete charts/ directory - Delete the templates/ directory - Remove all unrelated values.yaml Signed-off-by: timflannagan <[email protected]>
Signed-off-by: timflannagan <[email protected]>
Signed-off-by: timflannagan <[email protected]>
Signed-off-by: timflannagan <[email protected]>
Signed-off-by: timflannagan <[email protected]>
Signed-off-by: timflannagan <[email protected]>
timflannagan
changed the title
lgadban
reviewed
Mar 13, 2025
| # This is the chart version. This version number should be incremented each time you make changes | ||
| # to the chart and its templates, including the app version. | ||
| # Versions are expected to follow Semantic Versioning (https://semver.org/) | ||
| version: 0.1.0 |
There was a problem hiding this comment.
I think I'm missing something, but is this version relevant?
| package-kgateway-charts: package-kgateway-chart package-kgateway-crd-chart | ||
|
|
||
| .PHONY: package-kgateway-chart | ||
| package-kgateway-chart: ## Package the kgateway chart for testing |
There was a problem hiding this comment.
nit: is this comment accurate w.r.t. "for testing"?
Looks like this is the target used in the release workflow as well
| @@ -1,6 +1,6 @@ | |||
| apiVersion: v2 | |||
| name: kgateway | |||
| description: A Helm chart for Kubernetes | |||
| description: A Helm chart for the kgateway project | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces a dedicated CRD helm chart in preparation for the 2.0 release. This aligns with helm best practices w.r.t CRD management. See https://helm.sh/docs/chart_best_practices/custom_resource_definitions/#method-2-separate-charts for more information on this approach.
This is the first step towards auditing our install UX story. Having a dedicated chart before 2.0 is cut helps prevents any painful migrations for subsequent 2.x minor versions. See #10640 for some of the details captured there.
Checklist: