fix(developer): handle non bmp numeric entities in xml reader #13365
+31
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… XML reader fast-xml-reader has a bug with numeric entities. See: NaturalIntelligence/fast-xml-parser#725 This commit adds a unit test to verify that non-BMP numeric entities will be parsed correctly. It will fail until we update the fast-xml-parser dependency. Relates-to: #13348
keymanapp-test-bot
bot
added
the
user-test-missing
User Test ResultsTest specification and instructions ERROR: user tests have not yet been defined |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fast-xml-reader has a bug with numeric entities. See:
NaturalIntelligence/fast-xml-parser#725
This commit adds a unit test to verify that non-BMP numeric entities will be parsed correctly. It will fail until we update the fast-xml-parser dependency.
Relates-to: #13348
Waiting for fast-xml-parser update to be published to NPM