Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): Add breadcrumb when kmp file has no targets to install #13361

Draft
wants to merge 1 commit into
base: beta
Choose a base branch
from

Conversation

darcywong00
Copy link
Contributor

For investigating KEYMAN-ANDROID-251

No keyboards or predictive text to install

This adds a breadcrumb to get more info why a kmp file fails to install.

@keymanapp-test-bot skip

@darcywong00 darcywong00 added this to the B18S2 milestone Feb 27, 2025
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Feb 27, 2025

@darcywong00 darcywong00 marked this pull request as ready for review February 27, 2025 07:23
@jahorton
Copy link
Contributor

But it already has a breadcrumb for that: in my experience, the following breadcrumb always appears in the logs of that event (KEYMAN-ANDROID-251) and one other:

KMLog.LogBreadcrumb(TAG, "Determining package type for " + kmpFilename, false);

See also KEYMAN-ANDROID-4G.

In the instances I investigated, the packages turned out to be for legacy keyboards that were never designed with mobile / web in mind. @mcdurdin actually prompted that investigation, anticipating that analysis to be the case. So, "working as expected."

@darcywong00
Copy link
Contributor Author

But it already has a breadcrumb for that: in my experience, the following breadcrumb always appears in the logs of that event

Ok, going back to draft to analyze. I wonder if we set addStackTrace to true

@darcywong00 darcywong00 marked this pull request as draft February 27, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants